Open jfcherng opened 2 months ago
This PR doesn't do the following.
Technically, python
and pip
are not required if we use $ ruff server --preview
command to run the server. That means LSP-ruff
doesn't have to inherit PipClientHandler
. ruff
binary can be downloaded from its GitHub releases. The downside would be that the dependabot doesn't seem able to monitor the version change for new GitHub releases (or does it?). People can subscribe to ruff
releases on GitHub though.
I can spend some time to refactor this but before that I want to make sure that we are interested in this.
I think it makes sense to assume people who use ruff
(write python
) have python
installed on their machine. And likely so does pip
.
The changelog says that it's in alpha which makes me want to wait with switching to it since there might be potentially missing features or have bugs to iron out.
Fine. I will use it in my daily work to see if there is a critical bug.
BTW. We have github actions that can monitor github releases (used in LSP-rust-analyzer for example)
BTW. We have github actions that can monitor github releases (used in LSP-rust-analyzer for example)
Thanks for the info. I am pretty sure that is what I was looking for repositories I forgot...
I have one for LSP-clangd too https://github.com/sublimelsp/LSP-clangd/blob/main/.github/workflows/update_check.yaml
ruff
as a LSP server is in beta stage: https://github.com/astral-sh/ruff/releases/tag/v0.4.5
Proposal
As of
ruff
v0.4.0, it can be used as a LSP server. We no longer need theruff-lsp
Python wrapper. Plus,ruff
is even faster thanruff-lsp
, obviously.ref: https://github.com/astral-sh/ruff/releases/tag/v0.4.0
I am not going to keep tracking the latest
ruff
release in this PR. Remember to update the version number if you are going to merge this PR.The current latest
ruff
release can be found on https://github.com/astral-sh/ruff/releases/latest