munkybutt commented 1 month ago

Hey - with the latest update I have migrated across to the new settings but it seems like my "ruff.toml" file is ignored. I noticed my imports were no longer being sorted according to my isort rules and the behaviour remains the same if the "configuration" key is commented out or not. These are my settings:

{
    "initializationOptions": {
        "globalSettings": {
                        "configuration": "D:/p4/tools/dcc_tools/mg_tools/.projects/ruff.toml",
            "showNotification": "on",
            "organizeImports": true,
            "fixAll": true,
        },
    }
}

To confirm, the ruff.toml path does exist and it was working with the previous lsp-ruff version yesterday.

This is the contents of my ruff.toml

# Exclude a variety of commonly ignored directories.
exclude = [
    ".bzr",
    ".direnv",
    ".eggs",
    ".git",
    ".git-rewrite",
    ".hg",
    ".ipynb_checkpoints",
    ".mypy_cache",
    ".nox",
    ".pants.d",
    ".pyi",
    ".pyenv",
    ".pytest_cache",
    ".pytype",
    ".ruff_cache",
    ".svn",
    ".tox",
    ".venv",
    ".vscode",
    "__pypackages__",
    "_build",
    "buck-out",
    "build",
    "dist",
    "node_modules",
    "site-packages",
    "venv",
]

# Same as Black.
line-length = 100
indent-width = 4

# Assume Python 3.10
target-version = "py310"

[lint]
select = ["E", "F", "I"]
ignore = []

# Allow fix for all enabled rules (when `--fix`) is provided.
fixable = ["ALL"]
unfixable = []

# Allow unused variables when underscore-prefixed.
dummy-variable-rgx = "^(_+|(_+[a-zA-Z0-9_]*[a-zA-Z0-9]+?))$"

[lint.isort]
combine-as-imports = false
force-single-line = true
lines-between-types = 1
no-sections = true
required-imports = ["from __future__ import annotations"]

[format]
# Like Black, use double quotes for strings.
quote-style = "double"

# Like Black, indent with spaces, rather than tabs.
indent-style = "space"

# Like Black, respect magic trailing commas.
skip-magic-trailing-comma = false

# Like Black, automatically detect the appropriate line ending.
line-ending = "auto"

# Enable auto-formatting of code examples in docstrings. Markdown,
# reStructuredText code/literal blocks and doctests are all supported.
#
# This is currently disabled by default, but it is planned for this
# to be opt-out in the future.
docstring-code-format = true

# Set the line length limit used when formatting code snippets in
# docstrings.
#
# This only has an effect when the `docstring-code-format` setting is
# enabled.
docstring-code-line-length = "dynamic"

Any help would be appreciated

munkybutt commented 1 month ago

I just noticed that when I open my lsp-ruff.sublime-settings file this is printed to the console: Unable to open /C/Users/Shea.Richardson/AppData/Roaming/Sublime Text/Packages/LSP-ruff/LSP-ruff.sublime-settings

LDAP commented 1 month ago

@jfcherng

jfcherng commented 1 month ago

I just noticed that when I open my lsp-ruff.sublime-settings file this is printed to the console: Unable to open /C/Users/Shea.Richardson/AppData/Roaming/Sublime Text/Packages/LSP-ruff/LSP-ruff.sublime-settings

did you try to restart ST?

munkybutt commented 1 month ago

yes - restart ruff from command panel, restart ST. I have yet to uninstall/re-install lsp-ruff. I shall try that

munkybutt commented 1 month ago

Still the same after a re-install :(

munkybutt commented 1 month ago

The settings must be found as this prints when I save them: reloading settings Packages/User/LSP-ruff.sublime-settings

rchl commented 1 month ago

Can you show the output of LSP: Troubleshoot server? It shows effective settings that are used.

rchl commented 1 month ago

But if you are getting a message like Unable to open /C/Users/Shea.Richardson/AppData/Roaming/Sublime Text/Packages/LSP-ruff/LSP-ruff.sublime-settings then it means that the initializationOptions that you provided in your initial message are not saved in the correct file. In which files did you set those?

munkybutt commented 1 month ago

Here is the output of LSP: Troublshoot server

Troubleshooting: LSP-ruff

Version

LSP: 2.2.0
Sublime Text: 4169
Server Test Run
exit code: 0
output

## Server Configuration
 - command
```json
[
  "$server_path",
  "server"
]

shell command

"C:\Users\Shea.Richardson\AppData\Local\Sublime Text\Package Storage\LSP-ruff\Scripts\ruff.exe" server

selector
```
source.python
```
priority_selector
```
source.python
```

init_options

{
"globalSettings": {
"codeAction": {
  "disableRuleComment": {
    "enable": true
  },
  "fixViolation": {
    "enable": true
  }
},
"configuration": "D:/p4/tools/dcc_tools/mg_tools/.projects/ruff.toml",
"configurationPreference": "editorFirst",
"exclude": null,
"fixAll": true,
"format": {
  "preview": null
},
"lineLength": null,
"lint": {
  "enable": true,
  "extendSelect": null,
  "ignore": null,
  "preview": null,
  "select": null
},
"logLevel": "error",
"organizeImports": true,
"showNotification": "on"
},
"settings": {}
}

settings
```
{}
```

env

{
"PATH": "C:\\Users\\Shea.Richardson\\AppData\\Local\\Sublime Text\\Package Storage\\LSP-ruff\\Scripts;"
}

Active view

File name
```
None
```

Settings

{
"auto_complete_selector": null,
"lsp_active": null,
"syntax": null
}

Project / Workspace

folders

[
"D:\\p4\\tools\\dcc_tools\\mg_tools\\_standalone\\python",
"D:\\p4\\tools\\dcc_tools\\mg_tools\\unreal\\python"
]

is project: True

project data:

{
"debugger_configurations": [
{
  "connect": {
    "host": "localhost",
    "port": 7778
  },
  "justMyCode": false,
  "name": "Remote",
  "request": "attach",
  "type": "python"
}
],
"folders": [
{
  "file_exclude_patterns": [
    ".pyc"
  ],
  "folder_exclude_patterns": [
    "__pycache__",
    ".vscode",
    ".qt_for_python",
    "c#",
    "c++",
    "*.egg-info"
  ],
  "name": "standalone",
  "path": "../../_standalone/python"
},
{
  "file_exclude_patterns": [
    ".pyc"
  ],
  "folder_exclude_patterns": [
    "__pycache__",
    ".vscode",
    ".qt_for_python",
    "c#",
    "c++",
    "*.egg-info"
  ],
  "name": "unreal",
  "path": "../../unreal/python"
}
],
"settings": {
"LSP": {
  "LSP-basedpyright": {
    "settings": {
      "basedpyright.analysis.extraPaths": [
      ]
    }
  },
  "LSP-pyright": {
    "settings": {
      "python.analysis.extraPaths": [
      ]
    }
  }
}
}
}

LSP configuration

{
  "diagnostics_additional_delay_auto_complete_ms": 0,
  "diagnostics_delay_ms": 0,
  "diagnostics_gutter_marker": "dot",
  "diagnostics_highlight_style": {
    "error": "squiggly",
    "hint": "underline",
    "info": "underline",
    "warning": "squiggly"
  },
  "diagnostics_panel_include_severity_level": 4,
  "document_highlight_style": "underline",
  "inhibit_snippet_completions": false,
  "inhibit_word_completions": true,
  "log_debug": false,
  "log_max_size": 8192,
  "log_server": [],
  "lsp_code_actions_on_save": {
    "source.organizeImports": true
  },
  "lsp_format_on_save": false,
  "on_save_task_timeout_ms": 2000,
  "popup_max_characters_height": 1250,
  "popup_max_characters_width": 100,
  "semantic_highlighting": false,
  "show_code_actions": "annotation",
  "show_code_actions_in_hover": true,
  "show_code_lens": "annotation",
  "show_diagnostics_count_in_view_status": false,
  "show_diagnostics_in_view_status": true,
  "show_diagnostics_panel_on_save": 0,
  "show_diagnostics_severity_level": 4,
  "show_multiline_diagnostics_highlights": true,
  "show_references_in_quick_panel": false,
  "show_symbol_action_links": true,
  "show_view_status": true
}

System PATH

C:\Windows\system32
C:\Windows
C:\Windows\System32\Wbem
C:\Windows\System32\WindowsPowerShell\v1.0\
C:\Windows\System32\OpenSSH\
C:\Program Files\dotnet\
C:\Program Files\Perforce\
C:\Program Files\Common Files\Autodesk Shared\
C:\Program Files\Docker\Docker\resources\bin
C:\Program Files\PowerShell\7\
C:\Program Files\Git\cmd
C:\Program Files (x86)\Windows Kits\10\Windows Performance Toolkit\
D:\p4\tools\dcc_tools\mg_tools_standalone\python.envs.poetry\bin\
D:\p4\tools\dcc_tools\mg_tools_standalone\python.envs.pyenv\pyenv-win\bin
D:\p4\tools\dcc_tools\mg_tools_standalone\python.envs.pyenv\pyenv-win\shims
C:\Program Files\WindowsApps\Microsoft.OutlookForWindows_1.2024.111.100_x64__8wekyb3d8bbwe
C:\Users\Shea.Richardson.dotnet\tools
C:\Users\Shea.Richardson\AppData\Local\Microsoft\WindowsApps
C:\Users\Shea.Richardson\AppData\Local\Programs\Microsoft VS Code\bin
C:\Program Files\CMake\bin

munkybutt commented 1 month ago

And I save the settings to the file that is opened using the ST menu: Which is: C:\Users\Shea.Richardson\AppData\Roaming\Sublime Text\Packages\User\LSP-ruff.sublime-settings When the settings window opens is when the error prints that the file that has just been opened cannot be found 😕

jfcherng commented 1 month ago

Do you likely have your own custom override in Package/

And I save the settings to the file that is opened using the ST menu: Which is: C:\Users\Shea.Richardson\AppData\Roaming\Sublime Text\Packages\User\LSP-ruff.sublime-settings When the settings window opens is when the error prints that the file that has just been opened cannot be found 😕

So when you clike the menu item in your screenshot, the left pane is empty?

jfcherng commented 1 month ago

Huh wait, I see Unable to open /C/Users/jfcherng/AppData/Roaming/Sublime Text/Packages/LSP-ruff/LSP-ruff.sublime-settings in my console too.

jfcherng commented 1 month ago

Huh wait, I see Unable to open /C/Users/jfcherng/AppData/Roaming/Sublime Text/Packages/LSP-ruff/LSP-ruff.sublime-settings in my console too.

I think this is a ST bug. It happens for every plugin when open settings with side-by-side layout.

munkybutt commented 1 month ago

ah ok so red herring heh

munkybutt commented 1 month ago

Do you likely have your own custom override in Package/

And I save the settings to the file that is opened using the ST menu: Which is: C:\Users\Shea.Richardson\AppData\Roaming\Sublime Text\Packages\User\LSP-ruff.sublime-settings When the settings window opens is when the error prints that the file that has just been opened cannot be found 😕

So when you clike the menu item in your screenshot, the left pane is empty?

No override in packages

jfcherng commented 1 month ago

But that shouldn't matter. I am now trying to check how ruff server uses initializationOptions but I can't find any document about that.

munkybutt commented 1 month ago

initializationOptions worked prior to v2.0.0

jfcherng commented 1 month ago

what if you move everything in globalSettings into settings?

rchl commented 1 month ago

Based on neovim configuration examples in https://docs.astral.sh/ruff/editors/settings/#__tabbed_1_2 it should be:

{
    "initializationOptions": {
        "settings": {
            "configuration": "D:/p4/tools/dcc_tools/mg_tools/.projects/ruff.toml",
            "showNotification": "on",
            "organizeImports": true,
            "fixAll": true,
        },
    }
}

rchl commented 1 month ago

And options like showNotifications might not do anything for us. This is marked as VSCode specific.

jfcherng commented 1 month ago

I can't find any source about "globalSettings". If "settings" works, we can just move to it.

munkybutt commented 1 month ago

what if you move everything in globalSettings into settings?

this seems to have done the trick - tyty!

sublimelsp / LSP-ruff

2.0.0 seems to ignore "configuration" setting key #66

Troubleshooting: LSP-ruff

Version

Server Test Run

Active view

Project / Workspace

LSP configuration

System PATH