search

sublimelsp / LSP-typescript

TypeScript, JavaScript support for Sublime LSP plugin
MIT License
135 stars 11 forks source link

Bump typescript from 4.4.4 to 4.5.2 in #105

Closed dependabot[bot] closed 2 years ago

dependabot[bot] commented 2 years ago

Bumps typescript from 4.4.4 to 4.5.2.

Release notes

Sourced from typescript's releases.

TypeScript 4.5

For release notes, check out the release announcement.

For the complete list of fixed issues, check out the

Downloads are available on:

TypeScript 4.5 RC

For release notes, check out the release announcement.

For the complete list of fixed issues, check out the

Downloads are available on:

TypeScript 4.5 Beta

For release notes, check out the release announcement.

For the complete list of fixed issues, check out the

Downloads are available on:

Commits


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
rchl commented 2 years ago

Reverted this for now since I'm not very confident in it.

I know of some issues with "find callers" and generally being broken in Vue files. While latter doesn't necessarily affect this packge, it feels like it might have some issues that need a hotfix.

predragnikolic commented 2 years ago

I know of some issues with "find callers" and generally being broken in Vue files. While latter doesn't necessarily affect this packge, it feels like it might have some issues that need a hotfix.

Didn't really why you mention that something is broken in Vue files :)

Can you point to what exactly is broken with the newer version of tsserver?

rchl commented 2 years ago

The relevant issue is the one with the "find callers" returning more than it should (IMO).

The issue with Vue/Vetur is not relevant but since it's not clear why Vetur breaks yet, I'm just being cautious as it could be some generic Typescript issue.