sublimelsp / LSP-typescript

TypeScript, JavaScript support for Sublime LSP plugin
MIT License
135 stars 11 forks source link

Incorrect Action in Readme's "Code Actions On Save" Section #123

Closed EthanHipps closed 2 years ago

EthanHipps commented 2 years ago

Hello,

I noticed that the "Add Missing Imports" action, source.addMissingImports.ts, listed in the Readme's "Code Actions On Save" section doesn't match what LSP logs in the output window, source.SourceAddMissingImportsTs.ts.

I tested both and only source.SourceAddMissingImportsTs.ts worked for me.

Here's a screenshot of the LSP log.

image
rchl commented 2 years ago

It needs to fixed in https://github.com/typescript-language-server/typescript-language-server but I'll keep this open until the server version with the fix is pulled in. Thanks.

rchl commented 2 years ago

Fixed in https://github.com/sublimelsp/LSP-typescript/releases/tag/1.10.1

EthanHipps commented 2 years ago

Awesome. Thanks!