sublimelsp / LSP-typescript

TypeScript, JavaScript support for Sublime LSP plugin
MIT License
132 stars 11 forks source link

Can crash on comment alignment #198

Closed brian6932 closed 1 year ago

brian6932 commented 1 year ago

https://i.alienpls.org/tmV.apng

rchl commented 1 year ago

Is it really related to this package or it also happens with it disabled?

In any case, if it's related to this package then provide some details. Ideally a repo that reproduces, relevant configuration...

brian6932 commented 1 year ago

Is it really related to this package or it also happens with it disabled?

Only when it's enabled, seems like it only happens on a large amount of multi-line commenting

In any case, if it's related to this package then provide some details. Ideally a repo that reproduces, relevant configuration...

Sublime Build 4147 LSP v1.22.0 LSP-typescript v2.2.0

LSP.sublime-settings ```json { "lsp_format_on_save": true, "lsp_code_actions_on_save": { "source.fixAll": true }, "show_symbol_action_links": true, "inhibit_snippet_completions": true, "inhibit_word_completions": true, "show_inlay_hints": true } ```
LSP.typescript.sublime-settings ```json { "settings": { "javascript.format.semicolons": "remove" } } ```
rchl commented 1 year ago

Did you trigger file save just before it happened?

In any case, try in safe mode with just LSP and LSP-typescript installed. I'm doubtful that this package alone can trigger such issue.

brian6932 commented 1 year ago

Did you trigger file save just before it happened?

yes

In any case, try in safe mode with just LSP and LSP-typescript installed. I'm doubtful that this package alone can trigger such issue.

It doesn't seem like the formatter is working for me in safe mode for whatever reason, I did migrate the configs. I'll look into this when I have more time.

rchl commented 1 year ago

I think it might be a conflict with some other package you have installed.

rchl commented 1 year ago

Close due to lack of reproduction. We can re-open if you have some reproducible case.