Closed dependabot[bot] closed 2 years ago
Do not merge yet,
While I added the volar.format.initialIndent
and trying to run LSP: Format file
from the command palette with the following volar setting:
// LSP-volar.sublime-settings
{
"settings": {
"volar.format.initialIndent": {
"html": false,
"javascript": true
},
}
}
on a file that looks like this:
<template>
<div class="body">
</div>
</template>
<script>
let x = document.querySelector('body').accessKey
export default {
}
</script>
<style scoped>
.body {
background: red
}
</style>
I expect to see formatting changes, but I see no change.
I'm investigating this.
Note volar.format.initialIndent
works in VS code,
i wonder if there is any additional client glue code required for this to work.
It does work in coc-volar as well https://github.com/yaegassy/coc-volar/pull/209#issuecomment-1237947676 So the issue must be at my side :)
Here are server logs when running the format request in VS Code.
Here are server logs when running the format request in ST.
second try, I added the following settings to mimic all VS Code settings. but still no formatting in ST.
{
"settings": {
"volar.format.initialIndent": {
"html": false,
"javascript": false,
"css": false
},
"javascript.format.enable": true,
"javascript.format.insertSpaceAfterCommaDelimiter": true,
"javascript.format.insertSpaceAfterConstructor": false,
"javascript.format.insertSpaceAfterSemicolonInForStatements": true,
"javascript.format.insertSpaceBeforeAndAfterBinaryOperators": true,
"javascript.format.insertSpaceAfterKeywordsInControlFlowStatements": true,
"javascript.format.insertSpaceAfterFunctionKeywordForAnonymousFunctions": true,
"javascript.format.insertSpaceBeforeFunctionParenthesis": false,
"javascript.format.insertSpaceAfterOpeningAndBeforeClosingNonemptyParenthesis": false,
"javascript.format.insertSpaceAfterOpeningAndBeforeClosingNonemptyBrackets": false,
"javascript.format.insertSpaceAfterOpeningAndBeforeClosingNonemptyBraces": true,
"javascript.format.insertSpaceAfterOpeningAndBeforeClosingEmptyBraces": true,
"javascript.format.insertSpaceAfterOpeningAndBeforeClosingTemplateStringBraces": false,
"javascript.format.insertSpaceAfterOpeningAndBeforeClosingJsxExpressionBraces": false,
"javascript.format.placeOpenBraceOnNewLineForFunctions": false,
"javascript.format.placeOpenBraceOnNewLineForControlBlocks": false,
"javascript.format.semicolons": "ignore",
"css.format.enable": true,
"css.format.newlineBetweenSelectors": true,
"css.format.newlineBetweenRules": true,
"css.format.spaceAroundSelectorSeparator": false,
"css.format.braceStyle": "collapse",
"css.format.preserveNewLines": true,
"css.format.maxPreserveNewLines": null,
"html.format.enable": true,
"html.format.wrapLineLength": 120,
"html.format.unformatted": "wbr",
"html.format.contentUnformatted": "pre,code,textarea",
"html.format.indentInnerHtml": false,
"html.format.preserveNewLines": true,
"html.format.maxPreserveNewLines": null,
"html.format.indentHandlebars": false,
"html.format.extraLiners": "head, body, /html",
"html.format.wrapAttributes": "auto",
"html.format.wrapAttributesIndentSize": null,
"html.format.templating": false,
"html.format.unformattedContentDelimiter": "",
}
}
ST Logs:
'format': {'initialIndent': {'html': False, 'css': False, 'javascript': False}}
is still not respected.
Hi @predragnikolic, seems language server never send workspace/configuration
request for volar.format.initialIndent
after textDocument/formatting
, are you sure the local @volar/vue-language-server
version is v0.40.9?
@johnsoncodehk thanks for the pointer! I cloned volar and built it locally, and it worked.
It turns out that the package-lock.json in this PR prevented me from using the v0.40.9.
Bumps @volar/vue-language-server from 0.40.7 to 0.40.9.
Changelog
Sourced from
@volar/vue-language-server
's changelog.Commits
9374238
v0.40.927a16ee
v0.40.896e704d
chore: bump depsc3fc3dc
fix: volar.config.js not working since v0.40.7Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)