sublimelsp / LSP

Client implementation of the Language Server Protocol for Sublime Text
https://lsp.sublimetext.io/
MIT License
1.61k stars 182 forks source link

refactor: use native types and f-string #2459

Closed jfcherng closed 1 month ago

jfcherng commented 1 month ago

With from __future__ import annotations, in type annotations we can convert

Py38 new feature(s):


Not Done in this PR

By the way, we can upgrade flake8 to v7. We previously stayed at v5 because it won't complaint about unused imports, which is used in # type: .... Or, let's go ruff as linter/formatter (this is the setup for all my Python projects now 😄 ).

jfcherng commented 1 month ago

Okay, now there are only line length issues left.

predragnikolic commented 1 month ago

please ignore the failing CI, the test_did_change_before_did_close is a flaky test, we track it here -> https://github.com/sublimelsp/LSP/issues/2461

predragnikolic commented 1 month ago

Thanks for the changes

I'll merge this tomorrow