sublimelsp / lsp_utils

Module with LSP-related utilities for Sublime Text
https://sublimelsp.github.io/lsp_utils/
MIT License
13 stars 6 forks source link

fix(node): improve handling on "broken" Windows installations #101

Closed rchl closed 1 year ago

rchl commented 1 year ago

On some "broken" Windows installations, running subprocess with shell=True can result in error exit code being returned from "node --version" even though node itself completes successfully.

This was reported few times and one time the culprit was an AutuRun script that made non-interactive shell executions result in exiting with error code.

Since our paths are fully resolved with shutil.which, we shouldn't need the side effect of shell=True that makes PATH being inherited from the system.

Fixes #100