Make ST4 handler use AbstractPlugin installation flow

sublimelsp / lsp_utils

Module with LSP-related utilities for Sublime Text

https://sublimelsp.github.io/lsp_utils/

MIT License

16 stars 6 forks source link

Make ST4 handler use AbstractPlugin installation flow #33

Closed rchl closed 4 years ago

rchl commented 4 years ago

Instead of creating extra thread when installing server in ST4, use "AbstractPlugin.needs_update_or_installation" and co.

The advantages are:

no extra threads
lazy installation - only starts when associated file is opened
does not require ST restart after server was installed

Also, call "(un)register_plugin" as recommended by AbstractPlugin API.

rchl commented 4 years ago

I'm ready to merge this and will do so tomorrow if nobody stops me.

rwols commented 4 years ago

I only glanced over it :) but it looks like this will work as expected from what I can tell.

rchl commented 4 years ago

I've realized now that due to making server initialization lazy, the cleanup that would happen on plugin_unloaded (on upgrading LSP-* packages) will likely not happen... So that kinda defeats the purpose of having install_in_cache flag and updating packages one-by-one.