search

sublimelsp / lsp_utils

Module with LSP-related utilities for Sublime Text
https://sublimelsp.github.io/lsp_utils/
MIT License
16 stars 6 forks source link

Use new unittesting actions #83

Closed rchl closed 3 years ago

rchl commented 3 years ago

@randy3k might wanna check out the failure. Looks like a typo (.py.py).

randy3k commented 3 years ago

You could use the branch v1 (It is a convention for GitHub actions) for stability.

randy3k commented 3 years ago

ai, I forgot that the branch v1 is not yet lsp_utils compatible.

rchl commented 3 years ago

no worries, this can wait

randy3k commented 3 years ago

I have just pushed the new commits to v1.

The flow could be further simplified without the repository name and package name 😄 . I needed them because I am testing the action in UnitTesting repo.

      - uses: actions/checkout@v2
      - uses: SublimeText/UnitTesting/actions/setup@v1
        with:
          extra-packages: |
            sublimelsp/LSP@main
            sublimelsp/LSP-pyright
      - uses: SublimeText/UnitTesting/actions/run-tests@v1
rchl commented 3 years ago

Looking good now. Nice!

randy3k commented 3 years ago

Glad to know that. At least it is worth the effort.

randy3k commented 3 years ago

By the way, I noticed that you were testing against sublimelsp/LSP@main for ST4. If you want to test against the released version, you just need to put the prefix down, i.e., sublimelsp/LSP@4070- (assuming that there is no exact match for 4070-). The logic is here in case you wonder how it works.