sublimemarch / so-you-just-learned

So, you just learned that there are problems in the tech industry. What now?
Other
284 stars 18 forks source link

Update contributing.md #33

Closed sublimemarch closed 6 years ago

sublimemarch commented 7 years ago

I think we should add a description of our PR review process, which I suggest which formalize as:

  1. Submit a PR, tagging which issue it closes if relevant
  2. The three maintainers are assigned
  3. If 2/3 maintainers approve, we merge the PR.

I also think we should add a short description of the labels I just added, which are:

thejessleigh commented 6 years ago

I have a little bit of free time this afternoon. I'll try to get this knocked out.

sublimemarch commented 6 years ago

@thejessleigh just for future reference, make sure to put "Closes #(issue number)" in your PR to have it auto-close when we merge the PR.