search

sublimemarch / so-you-just-learned

So, you just learned that there are problems in the tech industry. What now?
Other
284 stars 18 forks source link

Only Maintainers can assign people to a pull request #56

Closed AdiraSlat closed 6 years ago

AdiraSlat commented 6 years ago

Contributing.md states that if you are submitting a pull request that you should assign all of the maintainers to the PR so that they can see and review it. As a non-Maintainer, I am unable to assign people to my PR.

thejessleigh commented 6 years ago

Oh, good call. Thanks!

sublimemarch commented 6 years ago

Do we want to change this to instead say that you should tag the maintainers in the pull request, and list our github handles?

thejessleigh commented 6 years ago

Oh, I also checked here to see if there was an issue open :P. I'll change the documentation tonight.

thejessleigh commented 6 years ago

Closed as of #58