Messages to federation contain blank display_name

lazyguru commented 2 months ago

Problem

Messages being sent in the queue have an empty display_name for users. This should not be possible given the display_name is the username in Lemmy:

Example message:

{
  "actor_id": "https://demo.sublinks.org/u/leo",
  "actor_type": "Person",
  "display_name": "",
  "bio": "",
  "matrix_user_id": null,
  "private_key": "-----BEGIN PRIVATE KEY-----\r\nMIIEvQIBADANBgkqhkiG9w0BAQEFAASCBKcwggSjAgEAAoIBAQDJ7J/V8LrbGdl0hAF9WO2uHRxe\r\nDsvskpQEafooPOlwBNB4pe1WdlEJw5yLEGGEHbRZwadl9cVZcBQOoDPxeYovFC8PJN/1wPt+Dwge\r\nE+IL/mPeRB84sipyex4KBQEkLu4TuJsiBVfzaUI5hqf3uMhqoklTs4vm5aiV6CRlKTjnOYPYm4jR\r\nSJB0LwZXLsBOFrtbXaO2oCrTgzMLQWdsoJbdumP0jvptvNKlFxHC95GNBvZK2qXJjw52/4G6ORZ2\r\ndkpe54FGyHCZifv6/XckB2Fde+yf+WcEbeDfHn8SOAlZhujtyxRNVvE8Qo6C2yhGLAO24dgXzZH0\r\nDs8W1oRLbFMjAgMBAAECggEAAyxJN12WNMLbZGsonNV3aADZb8RFbGfB6gSCTlHlYdcUMY57RBxi\r\n2fJCyk/3wFGOgnSPvViXK83I5ZFF5QRXFAtPUVUagdbw/MJJYIjzyI12+J39wZsnHe+/q+z333TZ\r\n/+Gq6mYcGN1CvFBYi698fWnPGNYdm4Nor/EFwA3dm4sy0mtls3HG3LcIJTLjtJhde6Pp/en648uA\r\nd76b3ahUrpVfrwuw8axpGCjgdZMXPT5Obq1U02hDd5u7S5AXHyPYGA+x7Cj8kCz2pKPKw1NhhCjn\r\nQMBVHPANFvsGPZPe5jrRD8Jo/AmdasjskGhnXGt9uBEzjR5kUtB+BtPdLp/pRQKBgQDQuOYgN1GG\r\n6hwEqjKgHRrsQm+L3Wtb56b618RyFI+rA+idT0tZt4BmrPi+pPqJJeyeo6r6ZYwPBsf7/IQnqrpR\r\nzvHo96Z/pTzStQMRXmlzxtwWwKWTSoiH/Tdl99mewsdPHE+aJgmmUsAfl2NOCeFFGs4hjPCa+W5t\r\nxrrEyf/S/QKBgQD3qYkMQBuAvMUxbes0VJiv+0qTMFeI1c38JfZycJXpgrfl8huRIEsQJDU0zU98\r\nE7EQmoaXHPo0S1XqQu9N3QT0e/WZVucYevHE0d02jZu66JgcDxNlCgX822lCd4TJcKlSVN2wpdkM\r\nqrLcoOancaZlZR5KNF69bAbLdis9n4/onwKBgFoZ52Wy26PU/gFZg38w8UVaLJMBI25KIwAYErp4\r\ne8iEaG84Irv5BhnMw5hw2aJI18tntdBf88Us1TnHOTlybvoPzsgV2C80InyHHWrrCbSr/Khpw1BB\r\nFY021ypSgwQQ6z8QZqCRmQrOoBdDH+A5TaCqQJ+lGtybnnsPFeMLnD71AoGAVoAmV9sEQCCulycX\r\nIX3ynnSchXA7ApX6jfkMbMgZ9Cct5+h57GRlE0wyMTEMc//EtlHidGEwmpc9eMbMIlvx4Rpym44Y\r\nxRob22yZYPZw0AVxK0uwsHehw8E2sHpiLKFm4lS14X7rolr0gc7JAO7W+U8qFyzXcj2K2gF59NoI\r\nP20CgYEAtbs+L28ShNqhIuOYMJ1/q79LgiA+usHo03virC8hclT29SIZv4VBoLQl8zxyfGT0eQi6\r\nmZ3L3K4R79EGjlmBBci9mz4qA/joiw9oTDNNMdURknJbEb9X9mYFkhGsI0HGcqIOnsiCtCIlSuhI\r\nFiDx4d3rD07cAHtHOFsaNWxaabM=\r\n-----END PRIVATE KEY-----\r\n",
  "public_key": "-----BEGIN PUBLIC KEY-----\r\nMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEAyeyf1fC62xnZdIQBfVjtrh0cXg7L7JKU\r\nBGn6KDzpcATQeKXtVnZRCcOcixBhhB20WcGnZfXFWXAUDqAz8XmKLxQvDyTf9cD7fg8IHhPiC/5j\r\n3kQfOLIqcnseCgUBJC7uE7ibIgVX82lCOYan97jIaqJJU7OL5uWolegkZSk45zmD2JuI0UiQdC8G\r\nVy7ATha7W12jtqAq04MzC0FnbKCW3bpj9I76bbzSpRcRwveRjQb2StqlyY8Odv+BujkWdnZKXueB\r\nRshwmYn7+v13JAdhXXvsn/lnBG3g3x5/EjgJWYbo7csUTVbxPEKOgtsoRiwDtuHYF82R9A7PFtaE\r\nS2xTIwIDAQAB\r\n-----END PUBLIC KEY-----\r\n"
}

Steps to reproduce

fire up the docker images
Go to http://localhost:15672/#/queues/%2F/actor_create_queue
Scroll down and expand "Get messages"
Click the "Get message(s)" button

Expected result

display_name should always be set. In the case of the example, I expect the display_name to be set to "leo"

lazyguru commented 2 months ago

Maybe I'm misremembering? I could swear in Lemmy that the display_name was the username and not modifiable by the user. Whereas "name" was modifiable and what was presented in the UI. (eg, display_name=lazyguru, name="Joe Constant). Regardless, whichever way it is in Sublinks, the message should be sending the "username" and the schema I was expecting is here: https://github.com/sublinks/sublinks-federation/blob/main/docs/json-schema/actor.schema.json#L20-L23

devanbenz commented 2 months ago

@lazyguru I'll pick this up while working on the refactor to how I'm sending messages from the API 👍 :D

sublinks / sublinks-api