search

sublinks / sublinks-api

MIT License
74 stars 18 forks source link

#373 Resolves immutable updatedAt column #383

Closed Pdzly closed 6 months ago

Pdzly commented 6 months ago

closes #373 ( wrongly named branch, please ignore the number)

urda commented 6 months ago

I'm not sure how I ended up closing this. I must have done it from CLI by mistake.

jgrim commented 6 months ago

@Pdzly I've thought more about this issue. I think we should remove the db triggers and let springboot manage updatedAt for the entities. Rather than removing the annotation I believe we should make the field mutable and allow springboot to handle it. I'd consider updating the annotations for update and create to be driven by the database timestamp like so:

@UpdateTimestamp(source = SourceType.DB) & @CreationTimestamp(source = SourceType.DB)

jgrim commented 6 months ago

Renamed branch to issue/373-slur-filter See new PR: https://github.com/sublinks/sublinks-api/pull/389