feat: 45: Adjust consumer for multiple routing keys

sublinks / sublinks-federation

Federation service for Sublinks

MIT License

11 stars 4 forks source link

feat: 45: Adjust consumer for multiple routing keys #46

Closed devanbenz closed 5 months ago

devanbenz commented 8 months ago

Adds ability for consumer to consume from multiple routing keys
splits up consumer logic depending on routed message

github-actions[bot] commented 8 months ago

Go test coverage: 2.7% for commit 9627b867b7f442536f62d4d9ecde5e31156d3680

View coverage for all packages

```diff # Package Name | Coverage + sublinks/sublinks-federation/internal/lemmy | 2.7% ```

lazyguru commented 8 months ago

Maybe I'm missing something, but doesn't this just effectively remove the value of routing keys? This code changes it so that a single consumer listens to all routing keys and handles each message in turn. I started adding support for routing keys in my PR (#43) in which I spin up separate consumers for different routing keys so that you can have a dedicated consumer for some actions and then a generic consumer for others. Creating a kind of priority queue, if you will.

devanbenz commented 8 months ago

Maybe I'm missing something, but doesn't this just effectively remove the value of routing keys? This code changes it so that a single consumer listens to all routing keys and handles each message in turn. I started adding support for routing keys in my PR (#43) in which I spin up separate consumers for different routing keys so that you can have a dedicated consumer for some actions and then a generic consumer for others. Creating a kind of priority queue, if you will.

Aha! For some reason I did not see that PR even though you had tagged me in it haha. Will close this and take a look tomorrow night :)