submarcos / django-vectortiles

Mapbox VectorTiles for django, with PostGIS or Python
https://django-vectortiles.readthedocs.io
MIT License
38 stars 11 forks source link

v1 #35

Closed submarcos closed 5 months ago

submarcos commented 1 year ago

✨ First official release

gitguardian[bot] commented 10 months ago

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | | | -------------- | ------------------ | ------------------------------ | ---------------- | --------------- | -------------------- | | [371130](https://dashboard.gitguardian.com/incidents/371130?occurrence=114789873) | Assigned | Django Secret Key | 634cae337466df42c71f0b3f7f679d46b63ea0e7 | test_vectortiles/settings/__init__.py | [View secret](https://github.com/submarcos/django-vectortiles/commit/634cae337466df42c71f0b3f7f679d46b63ea0e7#diff-2a976aa08827b2c87d2836a4b98275880a70a2171acf8604c392dcf4805c471bL23) | | [371130](https://dashboard.gitguardian.com/incidents/371130?occurrence=114868166) | Assigned | Django Secret Key | 7a075663dacee1ef787ab22b4b4d4abecc41226b | test_vectortiles/settings/__init__.py | [View secret](https://github.com/submarcos/django-vectortiles/commit/7a075663dacee1ef787ab22b4b4d4abecc41226b#diff-2a976aa08827b2c87d2836a4b98275880a70a2171acf8604c392dcf4805c471bL23) |
🛠 Guidelines to remediate hardcoded secrets
1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secrets safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices. 3. Revoke and [rotate these secrets](https://docs.gitguardian.com/secrets-detection/secrets-detection-engine/detectors/specifics/secret_key_in_django_config#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://docs.gitguardian.com/ggshield-docs/integrations/git-hooks/pre-commit?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to catch secret before it leaves your machine and ease remediation.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

codecov[bot] commented 10 months ago

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

:exclamation: No coverage uploaded for pull request base (master@686e906). Click here to learn what that means.

:exclamation: Current head f699606 differs from pull request most recent head 1b78807. Consider uploading reports for the commit 1b78807 to get more accurate results

Files Patch % Lines
vectortiles/mixins.py 89.87% 8 Missing :warning:
vectortiles/backends/python/__init__.py 28.57% 5 Missing :warning:
vectortiles/rest_framework/views.py 70.00% 3 Missing :warning:
vectortiles/backends/postgis/__init__.py 90.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #35 +/- ## ========================================= Coverage ? 89.83% ========================================= Files ? 13 Lines ? 305 Branches ? 0 ========================================= Hits ? 274 Misses ? 31 Partials ? 0 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.