Closed StefanBrand closed 3 years ago
Merging #5 (b31a150) into master (70514be) will not change coverage. The diff coverage is
100.00%
.
@@ Coverage Diff @@
## master #5 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 7 7
Lines 145 146 +1
=========================================
+ Hits 145 146 +1
Impacted Files | Coverage Δ | |
---|---|---|
vectortiles/postgis/mixins.py | 100.00% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 70514be...b31a150. Read the comment docs.
Thank you for your fix and your contrib. I hope to fix all these problems in future by writing a real custom SubQuery or Aggregate for this. #1 . Il will add many tests on each database type.
Thank you for merging so quickly! I'm looking forward to the new release so that I can easily use it in our project. :slightly_smiling_face:
When filtering for dates, this happened:
The reason is that
.format(features.query)
calls the__str__
method of thesql.Query
, which produces unparsed output.https://github.com/submarcos/django-vectortiles/blob/70514bef851e955726e0b5db49c06c3e177045dd/vectortiles/postgis/mixins.py#L32
This PR aims to fix this issue, by correctly passing the
params
to thecursor.execute()
function.