search

submariner-io / enhancements

Enhancement proposals for Submariner projects.
https://submariner.io/
Apache License 2.0
5 stars 24 forks source link

Broken link detected by CI #153

Closed github-actions[bot] closed 1 year ago

github-actions[bot] commented 1 year ago

Periodic link aliveness CI detected a broken link. Please see the periodic job results for details.

dfarrell07 commented 1 year ago

This link does work, and it seems syntactically correct/the only way. :thinking:

dfarrell07 commented 1 year ago

Debugging, this is what I have so far.

It broke when we upgraded from 228fbf4ffb2a86a65314866e9b2322b519fd885f to 4d97ad89bbb0de4be573a9d7a2fc0ce900afc519.

https://github.com/submariner-io/enhancements/actions?query=workflow%3APeriodic

There are not any code changes to the GHA between those versions, only docs changes and a bump of the underlying linter:

https://github.com/gaurav-nelson/github-action-markdown-link-check/compare/228fbf4ffb2a86a65314866e9b2322b519fd885f...4d97ad89bbb0de4be573a9d7a2fc0ce900afc519

The linter was bumped from 3.8.7 to 3.10.2:

https://github.com/gaurav-nelson/github-action-markdown-link-check/commit/ca705e7eb257dcc453056eb0ff7459897918ee66

Other people seem to have similar issues after the bump:

https://github.com/tcort/markdown-link-check/issues/91#issuecomment-1102492323 https://github.com/gaurav-nelson/github-action-markdown-link-check/pull/129#issuecomment-1103426066

The upstream lib reported a bug/added a UT for HTML anchors in https://github.com/tcort/markdown-link-check/pull/193, which is what we hit in https://github.com/submariner-io/submariner-website/pull/881. That's tracked by https://github.com/tcort/markdown-link-check/issues/195, which isn't fixed. But I don't think that's the same issue as we're hitting here or the comments above describe.

I feel like I may be missing something obvious, or this is a timeout/rate-limit with a wrong HTTP error code. It's nuts that very similar links work.

### Multiple Active Gateway Packet Flow with Globalnet
[Multiple Active Gateway Packet Flow with Globalnet](#multiple-active-gateway-packet-flow-with-globalnet)
[✖] #multiple-active-gateway-packet-flow-with-globalnet → Status: 404
### Multiple Active Gateway Packet Flow without Globalnet
[Multiple Active Gateway Packet Flow without Globalnet](#multiple-active-gateway-packet-flow-without-globalnet)
[✓] #multiple-active-gateway-packet-flow-without-globalnet
dfarrell07 commented 1 year ago

Maybe let's just revert back to 228fbf4ffb2a86a65314866e9b2322b519fd885f.