submariner-io / shipyard

Framework and scripts to create multiple Kubernetes clusters with kind (K8s in Docker) for local E2E testing and development.
https://submariner.io/for_developers/shipyard/
Apache License 2.0
46 stars 26 forks source link

Use cloud-provider-kind instead of MetalLB #1622

Closed skitt closed 2 months ago

skitt commented 5 months ago

kind has a cloud-provider which can take care of LoadBalancer-type services; this works fine with LB-mode Submariner, so use that instead of MetalLB.

Currently the command is installed as cmd, which is why it is renamed during container construction. This is fixed for the next release of the cloud-provider.

cloud-provider-kind runs in the foreground, so this wraps it in a container run alongside the kind clusters, on the host network. The container is stopped on cleanup.

The dependency version will be tracked using dependabot.

submariner-bot commented 5 months ago

🤖 Created branch: z_pr1622/skitt/cloud-provider-kind

skitt commented 5 months ago

Switching to draft because this leaves haproxy containers running (and shouldn’t).

github-actions[bot] commented 5 months ago

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] commented 4 months ago

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

yboaron commented 4 months ago

I think we should consider keeping MetalLB as well since it is the default LB provider for baremetal. Do you think we can support both methods?

github-actions[bot] commented 3 months ago

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

skitt commented 3 months ago

I think we should consider keeping MetalLB as well since it is the default LB provider for baremetal. Do you think we can support both methods?

We probably can, yes.

github-actions[bot] commented 3 months ago

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

submariner-bot commented 2 months ago

🤖 Closed branches: [z_pr1622/skitt/cloud-provider-kind]