search

submariner-io / subctl

CLI tool that provides helper commands to install, inspect, and troubleshoot a Submariner deployment.
Apache License 2.0
18 stars 23 forks source link

Update Submariner dependencies to v0.18.0-rc0 #1146

Closed submariner-bot closed 4 months ago

submariner-bot commented 4 months ago

Update Submariner dependencies to v0.18.0-rc0

submariner-bot commented 4 months ago

🤖 I see this PR is using the local branch workflow, ignoring it on my side, have fun! 🚀 Full E2E won't run until the "ready-to-test" label is applied. I will add it automatically once the PR has 2 approvals, or you can add it manually.

skitt commented 4 months ago

Regarding the Windows build failure, the build is failing because github.com/vishvananda/netns isn’t available on Windows.

go mod why github.com/vishvananda/netns says

# github.com/vishvananda/netns
github.com/submariner-io/subctl/cmd/subctl
github.com/submariner-io/submariner/test/e2e/redundancy
github.com/submariner-io/submariner/pkg/cable/wireguard
github.com/vishvananda/netlink
github.com/vishvananda/netns

So the problem is that subctl now pulls in the Wireguard cable through e2e, and that won’t build on Windows. This happens as a result of https://github.com/submariner-io/submariner/pull/3030. The fix is to hard-code the cable name rather than import it from the wireguard package; but doing that will require a re-release.

skitt commented 4 months ago

https://github.com/submariner-io/submariner/pull/3040 will fix the Windows build.