search

submariner-io / subctl

CLI tool that provides helper commands to install, inspect, and troubleshoot a Submariner deployment.
Apache License 2.0
16 stars 22 forks source link

Drop the dependency on wireguard in e2e #1147

Closed skitt closed 1 month ago

skitt commented 1 month ago

The dependency breaks Windows builds.

submariner-bot commented 1 month ago

🤖 Created branch: z_pr1147/skitt/drop-wireguard-dep 🚀 Full E2E won't run until the "ready-to-test" label is applied. I will add it automatically once the PR has 2 approvals, or you can add it manually.

tpantelis commented 1 month ago

The cross-build job doesn't run on draft PRs.

submariner-bot commented 1 month ago

🤖 Closed branches: [z_pr1147/skitt/drop-wireguard-dep]

tpantelis commented 1 month ago

Shouldn't we merge this?

tpantelis commented 1 month ago

I updated the commit hash.

skitt commented 1 month ago

Shouldn't we merge this?

Current devel isn’t affected by this, so there’s no urgency. The dependencies will all be aligned when v0.19.0-m0 is released.

tpantelis commented 1 month ago

Shouldn't we merge this?

Current devel isn’t affected by this, so there’s no urgency. The dependencies will all be aligned when v0.19.0-m0 is released.

yes but that won't be for a while and someone may push a subctl PR before that.

skitt commented 1 month ago

Shouldn't we merge this?

Current devel isn’t affected by this, so there’s no urgency. The dependencies will all be aligned when v0.19.0-m0 is released.

yes but that won't be for a while and someone may push a subctl PR before that.

Current devel isn’t affected by the dependency change.