`show versions` misreports the submariner version

[mkolesnik]

What happened: Running join with only image overrides causes versions to be misreported by subctl show versions:

# subctl show versions
Cluster "cluster1"
 ✓ Showing versions
COMPONENT             REPOSITORY           VERSION     
submariner            quay.io/submariner   0.13.0-m2   
submariner-operator   localhost:5000       local  

What you expected to happen:

# subctl show versions
Cluster "cluster1"
 ✓ Showing versions
COMPONENT             REPOSITORY           VERSION     
submariner            localhost:5000       local   
submariner-operator   localhost:5000       local  

How to reproduce it (as minimally and precisely as possible): subctl join --kubeconfig /go/src/github.com/submariner-io/submariner/output/kubeconfigs/kind-config-cluster1 --clusterid cluster1 --image-override submariner-gateway=localhost:5000/submariner-gateway:local --image-override submariner-route-agent=localhost:5000/submariner-route-agent:local --image-override submariner-globalnet=localhost:5000/submariner-globalnet:local --image-override submariner-networkplugin-syncer=localhost:5000/submariner-networkplugin-syncer:local --image-override submariner-operator=localhost:5000/submariner-operator:local --nattport 4500 --ikeport 500 --globalnet-cidr --natt=false --cable-driver libreswan /go/src/github.com/submariner-io/submariner/output/broker-info.subm

Anything else we need to know?: This is because show versions takes the info for submariner from the repo/ver, and not the actual image.

Environment:

• Diagnose information (use subctl diagnose all):
• Gather information (use subctl gather)
• Cloud provider or hardware configuration:
• Install tools:
• Others:

[mkolesnik]

This also happens with service discovery.

I'm working on a fix, the output will change slightly (to reflect all component images):

subctl show versions
Cluster "cluster1"
 ✓ Showing versions
COMPONENT                       REPOSITORY       VERSION   
submariner-gateway              localhost:5000   local     
submariner-routeagent           localhost:5000   local     
submariner-globalnet            localhost:5000   local     
submariner-operator             localhost:5000   local     
submariner-lighthouse-agent     localhost:5000   local     
submariner-lighthouse-coredns   localhost:5000   local