Healthcheck should reset the status message after successful connection

[sridhargaddam]

What happened: In a KIND Setup it was seen that even after the tunnels are successfully established, the Status Message in connections shows an error.

[sgaddam@localhost submariner-operator]$ kubectl describe gateway -n submariner-operator
Name:         cluster2-worker
Namespace:    submariner-operator
Labels:       <none>
Annotations:  update-timestamp: 1617178236
API Version:  submariner.io/v1
Kind:         Gateway
Metadata:
  Creation Timestamp:  2021-03-22T11:16:59Z
  Generation:          67293
  Resource Version:    2067426
  Self Link:           /apis/submariner.io/v1/namespaces/submariner-operator/gateways/cluster2-worker
  UID:                 282e697f-c3b7-450c-b3ec-beadfdfd5a00
Status:
  Connections:
    Endpoint:
      Backend:          libreswan
      cable_name:       submariner-cable-cluster1-172-17-0-6
      cluster_id:       cluster1
      Health Check IP:  10.1.96.0
      Hostname:         cluster1-worker
      nat_enabled:      false
      private_ip:       172.17.0.6
      public_ip:        
      Subnets:
        100.1.0.0/16
        10.1.0.0/16
    Latency RTT:
      Average:       489.822µs
      Last:          450.972µs
      Max:           88.033403ms
      Min:           62.172µs
      Std Dev:       366.115µs
    Status:          connected
    Status Message:  Failed to successfully ping the remote endpoint IP "10.1.96.0"
  Ha Status:         active
  Local Endpoint:
    Backend:          libreswan
    cable_name:       submariner-cable-cluster2-172-17-0-4
    cluster_id:       cluster2
    Health Check IP:  10.2.0.1
    Hostname:         cluster2-worker
    nat_enabled:      false
    private_ip:       172.17.0.4
    public_ip:        
    Subnets:
      100.2.0.0/16
      10.2.0.0/16
  Status Failure:  
  Version:         v0.9.0-m1-19-g4e8888d
Events:            <none>
[sgaddam@localhost submariner-operator]$

[stale[bot]]

This issue has been automatically marked as stale because it has not had activity for 60 days. It will be closed if no further activity occurs. Please make a comment if this issue/pr is still valid. Thank you for your contributions.

[tpantelis]

bump

[nyechiel]

@sridhargaddam have you done anything special to get into this state? I have a local kind setup running now with 0.9.1 and I am not seeing this issue:

$ kubectl describe gateway -n submariner-operator | grep Status
        f:haStatus:
Status:
    Status:          connected
    Status Message:  

[stale[bot]]

This issue has been automatically marked as stale because it has not had activity for 60 days. It will be closed if no further activity occurs. Please make a comment if this issue/pr is still valid. Thank you for your contributions.

[nyechiel]

@sridhargaddam is this still relevant?

[sridhargaddam]

I think this was fixed already by @aswinsuryan by resetting the pinger. Aswin, can you please confirm?

[sridhargaddam]

This issue is fixed in Submariner.