search

submariner-io / submariner

Networking component for interconnecting Pods and Services across Kubernetes clusters.
https://submariner.io
Apache License 2.0
2.41k stars 190 forks source link

Add loadbalancerIP and annotation to submariner LB service #2322

Open jbperrin88 opened 1 year ago

jbperrin88 commented 1 year ago

Hi there,

I would like to know if it'll be possible to add custom parameter for the loadBalancing service inside 'kind: Submariner'

We have no external Loadbalancing in our openshift cluster but we use MetalLB. It would be really usedfull to set MetalLB annotation and loadbalancerIP inside submariner service

Best regards

sridhargaddam commented 1 year ago

Hello @jbperrin88,

Can you elaborate it a bit, so that we know the use-case better? Like what kind of annotation you are looking at and why is it necessary etc.

jbperrin88 commented 1 year ago

When you use MetalLB , you need to define IpPool and set inside your service definition some custom information:

Inside submariner , you can already set 'type : LoadBalancer' when you force loadbalancer mode true.

I was trying to use it, by changing paramter inside the service defined by submariner but it'll be cound be override at anytime because i was using Operator install. (OLM)

If i instal only with SUBCTL , I may customize the service like i want.

Regards

dfarrell07 commented 1 year ago

What resource are you labeling?

dfarrell07 commented 1 year ago

Talking about this on the PR scrub, it seems this will require changes across the operator and main repos (at least). It would be good if we can make an enhancement proposal to figure out the changes, scope, before starting. @jbperrin88

https://github.com/submariner-io/enhancements/blob/devel/template.md

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had activity for 60 days. It will be closed if no further activity occurs. Please make a comment if this issue/pr is still valid. Thank you for your contributions.

github-actions[bot] commented 8 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] commented 4 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

dfarrell07 commented 4 months ago

This relates to if we want to use LB for bare metal deployments. Note also https://github.com/submariner-io/shipyard/pull/1622.

github-actions[bot] commented 3 days ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.