search

suborbital / docs

Documentation monorepo for Suborbital projects and products
https://docs.suborbital.dev
Apache License 2.0
8 stars 5 forks source link

Laura/59 add missing put options head request docs to the http runtime api #146

Closed LauraLangdon closed 2 years ago

LauraLangdon commented 2 years ago

Added missing put, options, and head http request methods to close Issue #59.

flaki commented 2 years ago

@LauraLangdon could you make sure the .idea folder is not in the PR? Either just make sure that it does not get committed, or I don't mind if you add it to .gitignore as part of the PR (it's not a big deal and not worth a separate PR)

github-actions[bot] commented 2 years ago

4 total issues, 1 error, and 3 warnings found for docs.suborbital.dev

Details

ERROR WCAG2AA.Principle1.Guideline1_4.1_4_3.G18.Fail ```html Search ``` This element has insufficient contrast at this conformance level. Expected a contrast ratio of at least 4.5:1, but text in this element has a contrast ratio of 2.27:1. Recommendation: change text colour to #000610. ---
WARNING WCAG2AA.Principle1.Guideline1_3.1_3_1.H48 ```html
Skip to main content ``` This element has "position: fixed". This may require scrolling in two dimensions, which is considered a failure of this Success Criterion. ---
WARNING WCAG2AA.Principle1.Guideline1_4.1_4_3_F24.F24.FGColour ```html / ``` Check that this element has an inherited background colour or image to complement the corresponding inline foreground colour. ---

📝 docs | :octocat: repo | 🙋🏽‍♀️ issues | 🏪 marketplace | A11yWatch

LauraLangdon commented 2 years ago

@LauraLangdon could you make sure the .idea folder is not in the PR? Either just make sure that it does not get committed, or I don't mind if you add it to .gitignore as part of the PR (it's not a big deal and not worth a separate PR)

Done!

github-actions[bot] commented 2 years ago

4 total issues, 1 error, and 3 warnings found for docs.suborbital.dev

Details

ERROR WCAG2AA.Principle1.Guideline1_4.1_4_3.G18.Fail ```html Search ``` This element has insufficient contrast at this conformance level. Expected a contrast ratio of at least 4.5:1, but text in this element has a contrast ratio of 2.27:1. Recommendation: change text colour to #000610. ---
WARNING WCAG2AA.Principle1.Guideline1_3.1_3_1.H48 ```html
Skip to main content ``` This element has "position: fixed". This may require scrolling in two dimensions, which is considered a failure of this Success Criterion. ---
WARNING WCAG2AA.Principle1.Guideline1_4.1_4_3_F24.F24.FGColour ```html / ``` Check that this element has an inherited background colour or image to complement the corresponding inline foreground colour. ---

📝 docs | :octocat: repo | 🙋🏽‍♀️ issues | 🏪 marketplace | A11yWatch

github-actions[bot] commented 2 years ago

4 total issues, 1 error, and 3 warnings found for docs.suborbital.dev

Details

ERROR WCAG2AA.Principle1.Guideline1_4.1_4_3.G18.Fail ```html Search ``` This element has insufficient contrast at this conformance level. Expected a contrast ratio of at least 4.5:1, but text in this element has a contrast ratio of 2.27:1. Recommendation: change text colour to #000610. ---
WARNING WCAG2AA.Principle1.Guideline1_3.1_3_1.H48 ```html
Skip to main content ``` This element has "position: fixed". This may require scrolling in two dimensions, which is considered a failure of this Success Criterion. ---
WARNING WCAG2AA.Principle1.Guideline1_4.1_4_3_F24.F24.FGColour ```html / ``` Check that this element has an inherited background colour or image to complement the corresponding inline foreground colour. ---

📝 docs | :octocat: repo | 🙋🏽‍♀️ issues | 🏪 marketplace | A11yWatch

github-actions[bot] commented 2 years ago

4 total issues, 1 error, and 3 warnings found for docs.suborbital.dev

Details

ERROR WCAG2AA.Principle1.Guideline1_4.1_4_3.G18.Fail ```html Search ``` This element has insufficient contrast at this conformance level. Expected a contrast ratio of at least 4.5:1, but text in this element has a contrast ratio of 2.27:1. Recommendation: change text colour to #000610. ---
WARNING WCAG2AA.Principle1.Guideline1_3.1_3_1.H48 ```html
Skip to main content ``` This element has "position: fixed". This may require scrolling in two dimensions, which is considered a failure of this Success Criterion. ---
WARNING WCAG2AA.Principle1.Guideline1_4.1_4_3_F24.F24.FGColour ```html / ``` Check that this element has an inherited background colour or image to complement the corresponding inline foreground colour. ---

📝 docs | :octocat: repo | 🙋🏽‍♀️ issues | 🏪 marketplace | A11yWatch

github-actions[bot] commented 2 years ago

4 total issues, 1 error, and 3 warnings found for docs.suborbital.dev

Details

ERROR WCAG2AA.Principle1.Guideline1_4.1_4_3.G18.Fail ```html Search ``` This element has insufficient contrast at this conformance level. Expected a contrast ratio of at least 4.5:1, but text in this element has a contrast ratio of 2.27:1. Recommendation: change text colour to #000610. ---
WARNING WCAG2AA.Principle1.Guideline1_3.1_3_1.H48 ```html
Skip to main content ``` This element has "position: fixed". This may require scrolling in two dimensions, which is considered a failure of this Success Criterion. ---
WARNING WCAG2AA.Principle1.Guideline1_4.1_4_3_F24.F24.FGColour ```html / ``` Check that this element has an inherited background colour or image to complement the corresponding inline foreground colour. ---

📝 docs | :octocat: repo | 🙋🏽‍♀️ issues | 🏪 marketplace | A11yWatch

github-actions[bot] commented 2 years ago

4 total issues, 1 error, and 3 warnings found for docs.suborbital.dev

Details

ERROR WCAG2AA.Principle1.Guideline1_4.1_4_3.G18.Fail ```html Search ``` This element has insufficient contrast at this conformance level. Expected a contrast ratio of at least 4.5:1, but text in this element has a contrast ratio of 2.27:1. Recommendation: change text colour to #000610. ---
WARNING WCAG2AA.Principle1.Guideline1_3.1_3_1.H48 ```html
Skip to main content ``` This element has "position: fixed". This may require scrolling in two dimensions, which is considered a failure of this Success Criterion. ---
WARNING WCAG2AA.Principle1.Guideline1_4.1_4_3_F24.F24.FGColour ```html / ``` Check that this element has an inherited background colour or image to complement the corresponding inline foreground colour. ---

📝 docs | :octocat: repo | 🙋🏽‍♀️ issues | 🏪 marketplace | A11yWatch

github-actions[bot] commented 2 years ago

4 total issues, 1 error, and 3 warnings found for docs.suborbital.dev

Details

ERROR WCAG2AA.Principle1.Guideline1_4.1_4_3.G18.Fail ```html Search ``` This element has insufficient contrast at this conformance level. Expected a contrast ratio of at least 4.5:1, but text in this element has a contrast ratio of 2.27:1. Recommendation: change text colour to #000610. ---
WARNING WCAG2AA.Principle1.Guideline1_3.1_3_1.H48 ```html
Skip to main content ``` This element has "position: fixed". This may require scrolling in two dimensions, which is considered a failure of this Success Criterion. ---
WARNING WCAG2AA.Principle1.Guideline1_4.1_4_3_F24.F24.FGColour ```html / ``` Check that this element has an inherited background colour or image to complement the corresponding inline foreground colour. ---

📝 docs | :octocat: repo | 🙋🏽‍♀️ issues | 🏪 marketplace | A11yWatch

flaki commented 2 years ago

@LauraLangdon could you link to the Reactr APIs on which you based the new docs information or tell a bit more about this PR and your research/context, to make review easier? (This is so I wouldn't have to go through and double-check every single API)

LauraLangdon commented 2 years ago

@LauraLangdon could you link to the Reactr APIs on which you based the new docs information or tell a bit more about this PR and your research/context, to make review easier? (This is so I wouldn't have to go through and double-check every single API)

Sure, I used the following and @ramonh helped me figure out the pattern matching with the already-documented methods:

JS/TS Rust TinyGo Swift