suborbital / docs

Documentation monorepo for Suborbital projects and products
https://docs.suborbital.dev
Apache License 2.0
8 stars 5 forks source link

fix link to get started from se2 landing page #179

Closed LauraLangdon closed 1 year ago

LauraLangdon commented 2 years ago

Currently the link to "Get Started" on the SE2 landing page gives "Page Not Found" if you arrive at the SE2 landing page from the docs homepage, but not if you arrive at it from the sidebar link, because coming from the docs homepage the link is https://docs.suborbital.dev/get-started but coming from the sidebar the link is https://docs.suborbital.dev/se2/get-started.

The tidy fix would change <Link to={useBaseUrl('se2')}> in Header.jsx, but for the moment we'll just do this.

vercel[bot] commented 2 years ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
docs ✅ Ready (Inspect) Visit Preview Oct 4, 2022 at 4:35PM (UTC)
LauraLangdon commented 2 years ago

I've filed an issue to fix the A11yWatch issues: https://github.com/suborbital/docs/issues/180

I'll fix the one that's failing so we can merge this and link to the docs on the new site, but won't make fixing all them a prerequisite to merging this one.

LauraLangdon commented 2 years ago

Hi @j-mendez! We're getting a failure on our test runs, and wondering if you might have any insight into it on your end. Here's the failure: https://github.com/suborbital/docs/actions/runs/3183863502/jobs/5191587868#step:3:139

Looks like a Rust problem?

Cheers!

j-mendez commented 2 years ago

Hi @j-mendez! We're getting a failure on our test runs, and wondering if you might have any insight into it on your end. Here's the failure: https://github.com/suborbital/docs/actions/runs/3183863502/jobs/5191587868#step:3:139

Looks like a Rust problem?

Cheers!

Hi @j-mendez! We're getting a failure on our test runs, and wondering if you might have any insight into it on your end. Here's the failure: https://github.com/suborbital/docs/actions/runs/3183863502/jobs/5191587868#step:3:139

Looks like a Rust problem?

Cheers!

Hi @LauraLangdon I can get to this issue later today. Indeed a Rust problem, thank you!

j-mendez commented 2 years ago

Hi @j-mendez! We're getting a failure on our test runs, and wondering if you might have any insight into it on your end. Here's the failure: https://github.com/suborbital/docs/actions/runs/3183863502/jobs/5191587868#step:3:139 Looks like a Rust problem? Cheers!

Hi @j-mendez! We're getting a failure on our test runs, and wondering if you might have any insight into it on your end. Here's the failure: https://github.com/suborbital/docs/actions/runs/3183863502/jobs/5191587868#step:3:139 Looks like a Rust problem? Cheers!

Hi @LauraLangdon I can get to this issue later today. Indeed a Rust problem, thank you!

@LauraLangdon you may be able to re-run the action and not get the error. Looking at the action time it ran - 5 hours ago there was a small bug pushed that has been fixed.

LauraLangdon commented 2 years ago

Looks like the error persists, @j-mendez. https://github.com/suborbital/docs/issues/180

Thanks so much for your help!

j-mendez commented 2 years ago

Looks like the error persists, @j-mendez. #180

Thanks so much for your help!

You are welcome, it looks like the docker image for the fix was not tagged so the version needs a hard update on the GH action to update this time.

      - uses: A11yWatch/github-action@v1.11.1
        with:
          WEBSITE_URL: https://docs.suborbital.dev
          FAIL_ERRORS_COUNT: 3
          UPGRADE: true
          # 3 is the number of warnings we get from Docusaurus-level code we can't fix, so this will
          # be the error floor for now
          TOKEN: ${{ secrets.GITHUB_TOKEN }}

After the upgrade reverting the flag to improve the speed of the CLI or keep it can be done.

github-actions[bot] commented 1 year ago

7 total issues, 1 error, and 6 warnings found for docs.suborbital.dev

Details

ERROR WCAG2AA.Principle1.Guideline1_4.1_4_3.G18.Fail ```html Search ``` This element has insufficient contrast at this conformance level. Expected a contrast ratio of at least 4.5:1, but text in this element has a contrast ratio of 2.27:1. Recommendation: change text colour to #000610. ---
WARNING WCAG2AA.Principle1.Guideline1_3.1_3_1.H48 ```html
``` If this element contains a navigation section, it is recommended that it be marked up as a list. ---
WARNING WCAG2AA.Principle1.Guideline1_3.1_3_1.H48 ```html
``` If this element contains a navigation section, it is recommended that it be marked up as a list. ---
WARNING WCAG2AA.Principle1.Guideline1_3.1_3_1.H48 ```html

📝 docs | :octocat: repo | 🙋🏽‍♀️ issues | 🏪 marketplace | A11yWatch