suborbital / docs

Documentation monorepo for Suborbital projects and products
https://docs.suborbital.dev
Apache License 2.0
8 stars 5 forks source link

Integrate fathom analytics #201

Closed hola-soy-milk closed 1 year ago

hola-soy-milk commented 1 year ago

Closes #200

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
docs ✅ Ready (Inspect) Visit Preview Dec 19, 2022 at 4:51PM (UTC)
github-actions[bot] commented 1 year ago

4 total issues, 0 errors, and 4 warnings found for docs.suborbital.dev

Details

WARNING WCAG2AA.Principle1.Guideline1_3.1_3_1.H48 ```html

📝 docs | :octocat: repo | 🙋🏽‍♀️ issues | 🏪 marketplace | A11yWatch

github-actions[bot] commented 1 year ago

4 total issues, 0 errors, and 4 warnings found for docs.suborbital.dev

Details

WARNING WCAG2AA.Principle1.Guideline1_3.1_3_1.H48 ```html

📝 docs | :octocat: repo | 🙋🏽‍♀️ issues | 🏪 marketplace | A11yWatch

callahad commented 1 year ago

Would've expected the package-lock.json to get updated, too?

hola-soy-milk commented 1 year ago

Hold up, good catch. I just noticed we have both a package-lock and a yarn-lock.

callahad commented 1 year ago

haha, awesome. Otherwise LGTM

github-actions[bot] commented 1 year ago

4 total issues, 0 errors, and 4 warnings found for docs.suborbital.dev

Details

WARNING WCAG2AA.Principle1.Guideline1_3.1_3_1.H48 ```html

📝 docs | :octocat: repo | 🙋🏽‍♀️ issues | 🏪 marketplace | A11yWatch

hola-soy-milk commented 1 year ago

Ok, so I thought we had to install via yarn, but it turns out npm install did the trick.

Do we maybe want to see about eliminating one of the two? Having one single source of truth when it comes to dependencies might be a best bet here.

I get nervous about having both a yarn.lock and a package-lock

hola-soy-milk commented 1 year ago

For reference: The website repo has both checked in but refers to yarn in the README

callahad commented 1 year ago

Yeah. Website should canonically be Yarn. Docs should canonically be NPM.

After merging this PR we should drop the mention of Yarn in the Docs README (and in the docs themselves, probably. folks using yarn know how to use yarn).

We should probably switch the website over to npm from Yarn, too, though that'll also require updating the vercel config (ideally via a PR to the suborbital/fleet repo)

hola-soy-milk commented 1 year ago

I'm +1 on this. Just integrating fathom into Network which uses npm and the consistency advocate in me is eager.

In the meantime, is this good to go?