Closed hola-soy-milk closed 1 year ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Updated |
---|---|---|---|
docs | ✅ Ready (Inspect) | Visit Preview | Dec 19, 2022 at 4:51PM (UTC) |
Would've expected the package-lock.json to get updated, too?
Hold up, good catch. I just noticed we have both a package-lock and a yarn-lock.
haha, awesome. Otherwise LGTM
Ok, so I thought we had to install via yarn, but it turns out npm install did the trick.
Do we maybe want to see about eliminating one of the two? Having one single source of truth when it comes to dependencies might be a best bet here.
I get nervous about having both a yarn.lock and a package-lock
For reference: The website repo has both checked in but refers to yarn in the README
Yeah. Website should canonically be Yarn. Docs should canonically be NPM.
After merging this PR we should drop the mention of Yarn in the Docs README (and in the docs themselves, probably. folks using yarn know how to use yarn).
We should probably switch the website over to npm from Yarn, too, though that'll also require updating the vercel config (ideally via a PR to the suborbital/fleet repo)
I'm +1 on this. Just integrating fathom into Network which uses npm and the consistency advocate in me is eager.
In the meantime, is this good to go?
Closes #200