Closed rnpridgeon closed 2 years ago
Turns out this is a bit more aggressive than it should be. Will revisit monday
The very first piece of review of whether we should find a different expression for "sanity". Reason: https://www.selfdefined.app/definitions/sanity-check/ (tldr it's ableist) (this also applies to the entirety of our codebase though, but this is the first one I'm reviewing that it came up)
renamed targets and scripts to smoketest
, removed sudo from clean up trap.
I'm not sure if sanity.yml
is a required name for the CI so I'll leave that as is for now and we can follow up on it later.
Compliments: https://github.com/suborbital/atmo/pull/137
Subo does not currently verify the directive when bundling projects which may result in unexpected errors when deploying a bundle.
This PR adds an additional step to the build process which will validate the augmented directive.
User defined directive
Without this change:
With this change: