search

suborbital / subo

The Suborbital CLI
Apache License 2.0
81 stars 24 forks source link

add Cloudflare deployer #232

Closed xtuc closed 1 year ago

xtuc commented 2 years ago

Originally reviewed in https://github.com/suborbital/subo/pull/229

danielledeleo commented 2 years ago

Looks like the failed lint is at builder/prereq_test.go:63:9. If you have golangci-lint installed you can run make lint from the project root. It's unfortunate that CI doesn't actually say what failed. 

WARN [linters context] gci: `local-prefixes` is deprecated, use `sections` and `prefix(github.com/suborbital)` instead.
builder/prereq_test.go:63:9: err declared but not used (typecheck)
            got, err := tt.prereq.GetCommand(tt.r)
xtuc commented 2 years ago

@jagger27 I can see image

but I didn't change that file and err is actually used bellow.

danielledeleo commented 2 years ago

Hi @xtuc, sorry for the delay. Could you try pulling in the latest main? The linter is being a bit aggressive here (we missed it because this specific check is disabled in go1.18).