suborbital / subo

The Suborbital CLI
Apache License 2.0
81 stars 24 forks source link

Improve subo-generated SCN manifest #331

Open flaki opened 2 years ago

flaki commented 2 years ago

As mentioned in suborbital/docs#154 we should consider updating the subo-generated templates adding the non-autocert option for the builder. We should consider which usecase to make default, but can also inline the commented-out other configuration in the manifest for ease of switching.

Relevant snippets of the current scc-controlplane-deployment.yaml template:

          ports:
            - containerPort: 8080
            - containerPort: 8443

          env:
            - name: SCC_DOMAIN
              value: "{{ .BuilderDomain }}"

            - name: SCC_TLS_PORT
              value: "8443"
    - protocol: TCP
      name: challenge
      port: 80
      targetPort: 8080
    - protocol: TCP
      name: https
      port: 443
      targetPort: 8443