search

suborbital / subo

The Suborbital CLI
Apache License 2.0
81 stars 24 forks source link

tweak(subo): Rename scc -> scn in subo everywhere #334

Closed javorszky closed 1 year ago

javorszky commented 2 years ago

Closes #332

Replaces #333

javorszky commented 2 years ago

It looks like there are a lot of linting-related changes that aren't related to the SCC -> SCN swap. Should we land those separately?

@ospencer on one hand I understand the need for it, on the other, the linting was broken in the previous version as it used the linting config from a previous version of gci.

I figured if I have to change some of the linting anyways, I might as well standardise the lints between subo and scn (gci and revive to unearth the import shadows).

To me it's a case of the boyscout rule (leave code looking better than you found it) in this case, and because it's somewhat related, I think it's fine to leave them in for now. Generally I try to separate out things into different PRs.

arbourd commented 1 year ago

Closing this as it has been done in suborbital/templates. Thanks @javorszky!