search

subosito / flutter-action

Flutter environment for use in GitHub Actions. It works on Linux, Windows, and macOS.
MIT License
2.28k stars 202 forks source link

flutter-version-file: pubspec.yaml wrongly resolving flutter version ? #328

Closed pierrecorsini closed 3 months ago

pierrecorsini commented 3 months ago

Hi

Action

 - name: Set up Flutter
      uses: subosito/flutter-action@v2
      with:
        flutter-version-file: pubspec.yaml

Pubspec docs (https://docs.flutter.dev/tools/pubspec)

environment:
  sdk: ^3.5.0

setup.sh VERSION="$(yq '.environment.flutter' "$VERSION_FILE")"

I do think setup.sh searches in environment.flutter whereas it should be searching in environment.sdk.

pierrecorsini commented 3 months ago 
Good

environment:
  sdk: ">=3.3.0 <4.0.0"
  flutter: 3.19.0

This is well documented , my bad. Closed.