subosito / flutter-action

Flutter environment for use in GitHub Actions. It works on Linux, Windows, and macOS.
MIT License
2.17k stars 193 forks source link

pub-cache path different for flutter and dart #89

Closed kuhnroyal closed 3 years ago

kuhnroyal commented 3 years ago

The action makes the flutter and dart executables available. flutter uses $FLUTTER_ROOT/.pub-cache dart uses $HOME/.pub-cache

It would be great if both use the same path and also if PUB_CACHE variable was exported to env. This should only be set if it does not already exist in the env.

subosito commented 3 years ago

@kuhnroyal I think this is a good idea to have the same path for dart and flutter cache. Do you think there is any potential issue with this? In your PR, we will use $FLUTTER_ROOT/.pub-cache, isn't it?

kuhnroyal commented 3 years ago

In your PR, we will use $FLUTTER_ROOT/.pub-cache, isn't it?

Yes, exactly. I don't see any issues. Maybe some private runners need to be re-configured if someone used $HOME/.pub-cache before, like I do.

subosito commented 3 years ago

Ok, got it. Thanks @kuhnroyal