search

subquery / network-app

dApp for Node Operators, consumers and delegators interact with SubQuery Network
https://app.subquery.network
GNU General Public License v3.0
14 stars 8 forks source link

Fix redelegateInfo #692

Closed mogithehurt closed 5 months ago

mogithehurt commented 6 months ago

Description

Fix redelegateInfo

Type of change

Please delete options that are not relevant.

HuberTRoy commented 5 months ago

Thanks for your PR.

Looks like there no problems at i18n file. It's a placeholder.

The problem seems like at here https://github.com/subquery/network-app/blob/main/src/pages/delegator/DoDelegate/DelegateFrom.tsx#L418.

Can you please change it? I think make it with useMemo would be good.

mogithehurt commented 5 months ago

Thanks for your PR.

Looks like there no problems at i18n file. It's a placeholder.

The problem seems like at here https://github.com/subquery/network-app/blob/main/src/pages/delegator/DoDelegate/DelegateFrom.tsx#L418.

Can you please change it? I think make it with useMemo would be good.

this pr is not related to https://github.com/subquery/network-app/issues/691, this is fixing redelegateInfo sentence.

HuberTRoy commented 5 months ago

Yes, I fixed your #691 at #693.

The sentence on i18n is good.

If re-delegate trigger from delegate, the placeholder of re-delegate should be 

t('delegate.redelegateInfo', {
  reIndexerName: selectedOption?.name,
  indexerName: indexerMetadata.name,
})

if re-delegate trigger from undelegate, the placeholder of re-delegate should be 

t('delegate.redelegateInfo', {
  reIndexerName:  indexerMetadata.name,
  indexerName: selectedOption?.name,
})