subraizada3 / 27gn950controller

Control bias lighting on the LG 27GN950 monitor
Other
63 stars 12 forks source link

Add support for 38GL950G #11

Closed fippse closed 2 years ago

fippse commented 2 years ago

Hey, it would be awesome if you added support for the predecessor - which should be pretty similar to the 38GN950G. Currently, it just says 'not monitors found'. Cheerio!

subraizada3 commented 2 years ago

Which OS are you using? Can you find the USB VID & PID of the monitor?

fippse commented 2 years ago

Hi, thank you. Windows 11. I think it is: VID: 043e, PID: 9a57 I did a quick edit locally and it works with the monitor.

subraizada3 commented 2 years ago

This commit should integrate that. Let me know if it works.

fippse commented 2 years ago

Awesome, that was quick. I don't understand the usage_page part but this doesn't work: if (vid, pid) in vids_pids.keys() and usage_page == 0xff01: .. No monitors found if (vid, pid) in vids_pids.keys(): this works though..

lamyipming commented 2 years ago

I have a 38GN950 connected to a displayport. Program also print out "No monitors found". The ID should be VID_043E&PID_9A8A

I found that the "usage page" of my device is 0xFF00 instead of 0xFF01

I removed the "usage_page" condition check and got through, but the monitor doesn't seem to respond to the demo commands.

subraizada3 commented 2 years ago

The latest version should now work with the 38GL with no modifications.

subraizada3 commented 2 years ago

@fippse were you able to test this again on the 38GL950G?

fippse commented 2 years ago

@subraizada3 Yeah, awesome it works nicely!