Early implementation of feature #10 - video sync (Prismatic)

subraizada3 / 27gn950controller

Control bias lighting on the LG 27GN950 monitor

Other

63 stars 12 forks source link

Early implementation of feature #10 - video sync (Prismatic) #13

Open imkebe opened 2 years ago

imkebe commented 2 years ago

New:

lightpack - wrapper to initialize and sync Prismatic via it's telnet API
lightsync - a generic module to handle multiple screen-grabbing engines

Changes:

gui - added button and methods for handling second nonblocking thread to sync with Prismatic

Removed:

None

Not implemented:

exception handling
remote sync engine availability sensing
multi-monitors

More in https://github.com/subraizada3/27gn950controller/issues/10 feature comment

subraizada3 commented 2 years ago

I tried this out today and it worked well. Prismatic does have some issues with display scaling / 4k monitors on Linux, but the functionality you've implemented for our side of the HTTP interface is working as expected.

I think it would be good to refactor this into a QWidget which the main application can load into itself. We will probably want multiple backends for video sync. You've already implemented 1 (Prismatic) and identified another (Hyperion). I'd like to implement one that uses X directly (for Linux), like what Maxr1998 mentioned in #10. There can be a dropdown in the main GUI which allows for a specific backend to be selected and activated.

I can work on refactoring your branch into the QWidget architecture over this week.

imkebe commented 2 years ago

Great! I was playing a little over the weekend.

Zrzut ekranu 2022-02-14 o 12 06 55

I think that we need a settings section to setup different grabbers. I was thinking that external grabber is a way to go because it already solves a problem in a mature way and it's OS agnostic. However i can see that we could have:

Native/Builtin
Prismatic
Hyperion/HyperHDR

And in settings we could choose one of them and show related parameters like IP address, port, etc.

P.S. Also i added tray icon. Overall I was thinking of removing buttons to setup colors in favour of dobleclick/longpress color[1--4] button to set them. And disabling brigtness dial when using Lightsync. However we need to read current color setting from the device.

frumble commented 1 year ago

Hey, any progress on this? HyperHDR support would be neat! Only HyperHDR supports Wayland, which is the way, the ecosystem moves.

imkebe commented 1 year ago

@frumble I'm working on new refreshed app using 27gn950controller library. HyperHDR is a Hyperion fork. I'm using a rawudp module for synchronization and it work well. I will post update when done.

zolex commented 9 months ago

bro, this is awesome! it works like acharm and has a super fast response time in video sync mode (the original LG UltraGear Control Center is pretty much useless because its so slow).

Thank you so much, finally I have the immersion I hoped to get when buying the 38GN950B <3

frumble commented 9 months ago

bro, this is awesome! it works like acharm and has a super fast response time in video sync mode (the original LG UltraGear Control Center is pretty much useless because its so slow).

I’m confused, haven’t heard back since May from him, in the post above he wrote that the tool needs a setting for different video grabbers. How do you use the code?

zolex commented 9 months ago

bro, this is awesome! it works like acharm and has a super fast response time in video sync mode (the original LG UltraGear Control Center is pretty much useless because its so slow).

I’m confused, haven’t heard back since May from him, in the post above he wrote that the tool needs a setting for different video grabbers. How do you use the code?

Here he described how to set it up.

https://github.com/subraizada3/27gn950controller/issues/10