Closed GoogleCodeExporter closed 9 years ago
Correction, add BELOW line 115 the code I mentioned. So you get this:
add_action( 'admin_menu', 'bp_album_add_admin_menu' );
add_action( 'network_admin_menu', 'bp_album_add_admin_menu' );
Apparently that works without collisions for MultiSite and non Multisite. You
may need to double up for ALL instances of admin_menu.
Original comment by ipstenu
on 27 Jan 2011 at 5:12
We finally got this defect sorted out as of 2011-11-26 in version
BP-Album+0.1.8.8, which you can download here:
http://code.google.com/p/buddypress-media/downloads/list
Basically, what happened was:
1) WordPress introduced a "Super Admin Network Menu" intended for people
running multi-blog sites in addition to their normal "Admin Site" menu.
2) They also introduced a field called "Network:" in the info block at the
beginning of the plugin loader file. If you set it to "false" and somebody
installs it on a regular site, it displays it as normal. If you set it as
"false" and somebody installs it on the "site" screen of a network install, it
shows up on the "site" screen of the network install, but if they install it on
the "network" screen of a network install, then it only shows up on the
"network" screen of that install.
If, however, they set "Network:" = true, the plugin will ONLY show up if it is
installed a) on a system that is in "network" mode, and b) if it is installed
using the plugin install menu on the "network" screen.
So that covers WordPress 3.1.
3) In addition to this, BuddyPress modified bp_core_check_avatar_type(),
breaking the function's contract (technically they should have thrown an E_WARN
DEPRECATED), but that one was easy to find and fix.
4) And in addition to this, BuddyPress set their network field to "true",
meaning it only showed up on the "network" screen, and making our menu
invisible as a result.
So, a lot of work to fix, but everything works now.
As an aside: It would totally rock if WordPress and BuddyPress shipped a
"Developer" version of their plugins developers to test against before
releasing the full version on the WP site. "Keep following the SVN and test
against that" isn't a reasonable answer. I was watching the core developers
making *dozens* of changes up to 15 minutes before launch.
^F^
https://www.pivotaltracker.com/story/show/10488573
Original comment by CarlRoett@gmail.com
on 27 Feb 2011 at 3:30
Original issue reported on code.google.com by
ipstenu
on 27 Jan 2011 at 4:58