Fix phpstan errors - Githubissues

subscribepro / subscribepro-magento2-ext

Subscribe Pro Magento 2 Integration Extension

MIT License

24 stars 22 forks source link

Fix phpstan errors #175

Open garthbrantley opened 1 year ago

garthbrantley commented 1 year ago

PRs: #262, #264, #265, #54, #266 Separate PR for each level of phpstan compliance.

[x] Level 1
[x] Level 2
[x] Level 3
[x] Level 4

eugene-shab commented 8 months ago

@garthbrantley Added fixes for 4 levels of PHPStan errors. The config (phpstan.neon) has also been added to the module root dir. Instructions for using PHPStan were added to the Readme file.

Fixed scope for DataObject in the library (separate pull request)

garthbrantley commented 7 months ago

@eugene-shab Still needs more work. We want to pass:

bin/analyze --level=4 src/app/code/Swarming/SubscribePro
when the extension is installed inside Mark Shust docker stack