search

subscribepro / subscribepro-magento2-ext

Subscribe Pro Magento 2 Integration Extension
MIT License
24 stars 22 forks source link

My Subscriptions | Virtual Product | Unable to update subscription #186

Closed chrismshea closed 1 year ago

chrismshea commented 1 year ago

PR: #46

When attempting to update a subscription with the Native my subscription widget on a subscription for a virtual product it fails with a 409 and Please enter a first name. Field: firstName Value:

This is because an empty shipping address array is being sent like the following

        "shipping_address": [

        ],

When virtual product shipping address should not be sent.

czettnersandor commented 1 year ago

@chrismshea Please describe what Native means. I just tested editing subscriptions for virtual products multiple times, and I can change periods, can restart and stop subscriptions in the customer's My Account pages

chrismshea commented 1 year ago

@czettnersandor native meaning that in configuration you are NOT setup to use the hosted my subscriptions widget. In Swarming > Subscribe Pro > Advanced: set Enable Hosted My Subscriptions Page = No

czettnersandor commented 1 year ago

@chrismshea Thanks. I can reproduce the error, but not getting the same error message. The reasonPhrase it "Conflict" and the error sent back to the frontend is {"message":"An error occurred while updating interval."}

I trust the issue you described is because of the empty shipping_address array, so I'm changing that

czettnersandor commented 1 year ago

Fixed in https://github.com/subscribepro/subscribepro-php/pull/46