Cart price rule issue reported - `reorder_ordinal`

[garthbrantley]

PRs: #245

Ensure that Reorder Ordinal is not set on cart line items when orders created using the

• Reorder feature by customer on front-end of M2 site in My Account
• Reorder feature used by admins in M2 admin panel

Bug Report

There are two scenarios through which a reorder ordinal can (incorrectly) make its way into a quote / cart in Adobe Commerce. This allows for undesired application of cart price rules / discounts that are based on reorder ordinals in the conditions:

Reorder (from My Account > My Orders) of a recurring order Failed recurring order (if it gets far enough to create a quote) There is financial / revenue impact to both of these, while the first is obviously likely to be more prevalent.

To address this, a possible technical approach might be an observer for the sales_quote_save_before​ Adobe Commerce event, where the execute()​ function would loop through the items being added to the quote and strip out reorder_ordinal, subscription_id, and any other data which shouldn't persist into a new order.

[eugene-shab]

@garthbrantley If I understand correctly, the quote that is created during reordering should not contain reorder_ordinary.

Can you provide if are there specific steps to reproduce a quote with an established value of reorder_ordinary?

I have tested different variations of reorder creation, reorder_ordinary value appears only when creating an order from the platform with the quote value is_fulfilling = true and reorder_ordinary = value, in other cases (My account and admin panel) quotes are created with create_new_subscription_at_checkout = true and without reoder_ordinary

[garthbrantley]

@chrismshea Can you attempt to reproduce this and then document steps-to-reproduce?

[chrismshea]

Below Steps were done from Main at 4859774

Steps to reproduce

1. On Magento 2 Frontend create a new subscription.
2. From Subscribe Pro create a Recurring type reorder
3. Verify the id of the order in Magento 2
4. View the ordinal sent in the sales_order_item table.
5. From the Customer My Account > My Orders find the successful recurring order placed
6. Continue with a One Time Order
7. Note there is a subscription discount applied
8. View the placed order and note the interval and subscription id from the original recurring order from SP
9. View the record in the DB sales_order_item table, and see the reorder_ordinal used from the original recurring order from SP
10. Same results occur if choosing regular deliver from reorder of original recurring order.

These issues do not occur if doing a reorder from the sp recurring order in the admin one time or regular.

1. Create reorder from recurring order in admin
2. No subscription created, and no reused ordinal or sub id
3. Create a regular delivery order from recurring order
4. Subscription created, and new sub id and no reorder_ordinal

[eugene-shab]

@garthbrantley Since during the reorder the data for the new quote is taken from the old one, I saved the default values for the subscription options. Now when the reorderer is triggered, item options will be reset