Closed garthbrantley closed 10 months ago
@garthbrantley If I understand correctly, the quote that is created during reordering should not contain reorder_ordinary
.
Can you provide if are there specific steps to reproduce a quote with an established value of reorder_ordinary
?
I have tested different variations of reorder creation, reorder_ordinary
value appears only when creating an order from the platform with the quote value is_fulfilling
= true and reorder_ordinary
= value, in other cases (My account and admin panel) quotes are created with create_new_subscription_at_checkout
= true and without reoder_ordinary
@chrismshea Can you attempt to reproduce this and then document steps-to-reproduce?
sales_order_item
table.
interval
and subscription id
from the original recurring order from SP
sales_order_item
table, and see the reorder_ordinal
used from the original recurring order from SP
@garthbrantley Since during the reorder the data for the new quote is taken from the old one, I saved the default values for the subscription options. Now when the reorderer is triggered, item options will be reset
PRs: #245
Ensure that Reorder Ordinal is not set on cart line items when orders created using the
Bug Report
There are two scenarios through which a reorder ordinal can (incorrectly) make its way into a quote / cart in Adobe Commerce. This allows for undesired application of cart price rules / discounts that are based on reorder ordinals in the conditions:
Reorder (from My Account > My Orders) of a recurring order Failed recurring order (if it gets far enough to create a quote) There is financial / revenue impact to both of these, while the first is obviously likely to be more prevalent.
To address this, a possible technical approach might be an observer for the sales_quote_save_before Adobe Commerce event, where the execute() function would loop through the items being added to the quote and strip out reorder_ordinal, subscription_id, and any other data which shouldn't persist into a new order.