search

subsoap / defos

Extra native OS functions for games written using the Defold game engine
Creative Commons Zero v1.0 Universal
119 stars 16 forks source link

Read initial window size and position from game.project #124

Closed AGulev closed 3 years ago

AGulev commented 3 years ago

Pls don't merge before releasing Defold with this fix (PR)

subsoap commented 3 years ago

Looks good, you can merge whenever the Defold fix happens.

dapetcu21 commented 3 years ago

I would make this set the view size, not the window size, since the window size also includes window chrome (titlebar, window borders, etc.)

AGulev commented 3 years ago

@dapetcu21 I didn't know about this method, I'll take a look. Thank you!

AGulev commented 3 years ago

Could somebody test in on windows? (on mac it works perfect) http://d.defold.com/alpha/

AGulev commented 3 years ago

@dapetcu21 I use set_view instead of set_window

AGulev commented 3 years ago

Sep-21-2021 18-32-42

dapetcu21 commented 3 years ago

I think you forgot to change the name of the props. You only changed them in the README

AGulev commented 3 years ago

🙉 fixed!

subsoap commented 3 years ago

@AGulev I believe this can be merged now?

https://forum.defold.com/t/defold-1-2-188-has-been-released/69477?u=pkeod

AGulev commented 3 years ago

@subsoap yes, thank you