list of supported resolutions and other display info of monitor - Githubissues

subsoap / defos

Extra native OS functions for games written using the Defold game engine

Creative Commons Zero v1.0 Universal

113 stars 15 forks source link

list of supported resolutions and other display info of monitor #67

Closed chaosddp closed 5 years ago

chaosddp commented 6 years ago

for windows

AGulev commented 6 years ago

I added macos support. I made all the same way as in @chaosddp code, but in my opinion would be better to use dmArray array for data transfer from platform code, to crosplatform code. What do you think?

chaosddp commented 6 years ago

Done for Windows @AGulev, and i will have a try on the linux branch later.

AGulev commented 6 years ago

@chaosddp Cool! I'll do the same for macos today later.

AGulev commented 6 years ago

@chaosddp macOS changes are done

chaosddp commented 6 years ago

I will have a check if we can have Linux support later, then merge it.

subsoap commented 6 years ago

Was anyone with a Linux machine able to review this?

dapetcu21 commented 5 years ago

This is good, but I think there isn't enough information to go on in there. For example, display placement and scaling is also useful. (For example, a use-case would be to center the window on a specific display with set_window_size()). See my proposal here: https://github.com/subsoap/defos/issues/87

I have some time this week to work on this and add all the extra info in those tables. I also have access to a Windows + Linux PC and I'll test on both

dapetcu21 commented 5 years ago

So I added three new functions:

defos.get_displays(), which gives you info about the current multi-display layout
defos.get_current_display_id(), which tells you which display the game's window is currently on
defos.get_display_modes(), which gives you all the available resolution modes for one display

I also went through the Linux implementation and filled in the gaps wherever I could. I still have the Windows version of those functions to do before this is mergeable.

I couldn't get disable_minimize_button() / disable_maximize_button() to work for me (I'm on Elementary). Can somebody with another DE check if it works for them?

dapetcu21 commented 5 years ago

The Window port should be done, so this can be merged. I also fixed up some other Windows bugs. We seem to be having a few other simple features in the backlog that I could have a go at while I'm at it.

Closes #87

dapetcu21 commented 5 years ago

Aaand I think this should be enough for a release

subsoap commented 5 years ago

Tested on Windows 10. Tested new functions. No issues!

dapetcu21 commented 5 years ago

Hmm... I just figured... Reporting of rotated modes is not consistent across platforms. Give me just a bit...