search

subspace / infra

7 stars 4 forks source link

Upgrade gemini 3h #288

Closed DaMandal0rian closed 3 months ago

DaMandal0rian commented 3 months ago

User description

  1. bump gemini-3h release to mar-14
  2. bump gemini-3h release to mar-18

Type

enhancement

Description

Changes walkthrough

Relevant files
Configuration changes
main.tf
Update Docker Tag for Gemini-3h Deployment                             
aws/gemini-3h/main.tf
  • Updated docker-tag for various instance types from
    "gemini-3h-2024-mar-11" to "gemini-3h-2024-mar-18".
    		•  +6/-6     

    ✨ PR-Agent usage: Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

    github-actions[bot] commented 3 months ago

    PR Description updated to latest commit (https://github.com/subspace/infra/commit/20591f51b5706de2d49bcfbe0799a0c6c1fc7bd6)

    github-actions[bot] commented 3 months ago

    PR Review

    ⏱️ Estimated effort to review [1-5] 1, because the PR involves a straightforward update of the `docker-tag` value across various instance types in a Terraform configuration file. The changes are repetitive and do not introduce complex logic or new features.
    🧪 Relevant tests No
    🔍 Possible issues No
    🔒 Security concerns No
    Code feedback:
    ✨ Review tool usage guide:
    **Overview:** The `review` tool scans the PR code changes, and generates a PR review. The tool can be triggered [automatically](https://pr-agent-docs.codium.ai/usage-guide/automations_and_usage/#github-app-automatic-tools-when-a-new-pr-is-opened) every time a new PR is opened, or can be invoked manually by commenting on any PR. When commenting, to edit [configurations](https://github.com/Codium-ai/pr-agent/blob/main/pr_agent/settings/configuration.toml#L19) related to the review tool (`pr_reviewer` section), use the following template: ``` /review --pr_reviewer.some_config1=... --pr_reviewer.some_config2=... ``` With a [configuration file](https://pr-agent-docs.codium.ai/usage-guide/configuration_options/), use the following template: ``` [pr_reviewer] some_config1=... some_config2=... ```
    Utilizing extra instructions
    The `review` tool can be configured with extra instructions, which can be used to guide the model to a feedback tailored to the needs of your project. Be specific, clear, and concise in the instructions. With extra instructions, you are the prompter. Specify the relevant sub-tool, and the relevant aspects of the PR that you want to emphasize. Examples for extra instructions: ``` [pr_reviewer] # /review # extra_instructions=""" In the 'possible issues' section, emphasize the following: - Does the code logic cover relevant edge cases? - Is the code logic clear and easy to understand? - Is the code logic efficient? ... """ ``` Use triple quotes to write multi-line instructions. Use bullet points to make the instructions more readable.
    How to enable\disable automation
    - When you first install PR-Agent app, the [default mode](https://pr-agent-docs.codium.ai/usage-guide/automations_and_usage/#github-app-automatic-tools-when-a-new-pr-is-opened) for the `review` tool is: ``` pr_commands = ["/review", ...] ``` meaning the `review` tool will run automatically on every PR, with the default configuration. Edit this field to enable/disable the tool, or to change the used configurations
    Auto-labels
    The `review` tool can auto-generate two specific types of labels for a PR: - a `possible security issue` label, that detects possible [security issues](https://github.com/Codium-ai/pr-agent/blob/tr/user_description/pr_agent/settings/pr_reviewer_prompts.toml#L136) (`enable_review_labels_security` flag) - a `Review effort [1-5]: x` label, where x is the estimated effort to review the PR (`enable_review_labels_effort` flag)
    Extra sub-tools
    The `review` tool provides a collection of possible feedbacks about a PR. It is recommended to review the [possible options](https://pr-agent-docs.codium.ai/tools/review/#enabledisable-features), and choose the ones relevant for your use case. Some of the feature that are disabled by default are quite useful, and should be considered for enabling. For example: `require_score_review`, `require_soc2_ticket`, `require_can_be_split_review`, and more.
    Auto-approve PRs
    By invoking: ``` /review auto_approve ``` The tool will automatically approve the PR, and add a comment with the approval. To ensure safety, the auto-approval feature is disabled by default. To enable auto-approval, you need to actively set in a pre-defined configuration file the following: ``` [pr_reviewer] enable_auto_approval = true ``` (this specific flag cannot be set with a command line argument, only in the configuration file, committed to the repository) You can also enable auto-approval only if the PR meets certain requirements, such as that the `estimated_review_effort` is equal or below a certain threshold, by adjusting the flag: ``` [pr_reviewer] maximal_review_effort = 5 ```
    More PR-Agent commands
    > To invoke the PR-Agent, add a comment using one of the following commands: > - **/review**: Request a review of your Pull Request. > - **/describe**: Update the PR title and description based on the contents of the PR. > - **/improve [--extended]**: Suggest code improvements. Extended mode provides a higher quality feedback. > - **/ask \**: Ask a question about the PR. > - **/update_changelog**: Update the changelog based on the PR's contents. > - **/add_docs** 💎: Generate docstring for new components introduced in the PR. > - **/generate_labels** 💎: Generate labels for the PR based on the PR's contents. > - **/analyze** 💎: Automatically analyzes the PR, and presents changes walkthrough for each component. >See the [tools guide](https://pr-agent-docs.codium.ai/tools/) for more details. >To list the possible configuration parameters, add a **/config** comment.
    See the [review usage](https://pr-agent-docs.codium.ai/tools/review/) page for a comprehensive guide on using this tool.
    github-actions[bot] commented 3 months ago

    PR Code Suggestions

    CategorySuggestions                                                                                                                                                       
    Enhancement
    Use a variable for the docker-tag to improve maintainability. ___ **Consider using a variable for the docker-tag to make future updates easier and reduce the
    risk of inconsistencies across different modules. This approach enhances maintainability
    and ensures consistency across your Terraform configurations.** [aws/gemini-3h/main.tf [12]](https://github.com/subspace/infra/pull/288/files#diff-3b7afab743a8ac1f8a135884fcdd27a3f4f1043827878079cdd906fac167dc40R12-R12) ```diff -docker-tag = "gemini-3h-2024-mar-18" +docker-tag = var.docker_tag ```
    Make reserved-only configurable for flexible deployment strategies. ___ **For better resource management and to avoid potential future costs, consider setting the
    reserved-only flag based on an environment variable or a Terraform variable. This allows
    for more flexibility in deployment strategies.** [aws/gemini-3h/main.tf [13]](https://github.com/subspace/infra/pull/288/files#diff-3b7afab743a8ac1f8a135884fcdd27a3f4f1043827878079cdd906fac167dc40R13-R13) ```diff -reserved-only = false +reserved-only = var.reserved_only ```
    Best practice
    Parameterize instance-count values for scalability and easier management. ___ **To ensure that your infrastructure can be easily scaled and managed, consider
    parameterizing the instance-count values by using variables or data sources that can be
    dynamically adjusted based on environment or demand.** [aws/gemini-3h/main.tf [10]](https://github.com/subspace/infra/pull/288/files#diff-3b7afab743a8ac1f8a135884fcdd27a3f4f1043827878079cdd906fac167dc40R10-R10) ```diff -instance-count = var.instance_count["bootstrap"] +instance-count = lookup(var.instance_counts, "bootstrap", default_instance_count) ```
    Cost-saving
    Make prune configurable to control resource management. ___ **To avoid unnecessary infrastructure costs, consider making the prune option configurable
    through a variable. This allows for more control over when and how resources are pruned.** [aws/gemini-3h/main.tf [14]](https://github.com/subspace/infra/pull/288/files#diff-3b7afab743a8ac1f8a135884fcdd27a3f4f1043827878079cdd906fac167dc40R14-R14) ```diff -prune = false +prune = var.prune ```
    Security
    Parameterize genesis-hash for easy updates and improved security. ___ **Ensure that the genesis-hash is kept up-to-date and consider parameterizing it to allow
    for easy updates without modifying the code directly. This can help in maintaining the
    integrity and security of the network.** [aws/gemini-3h/main.tf [15]](https://github.com/subspace/infra/pull/288/files#diff-3b7afab743a8ac1f8a135884fcdd27a3f4f1043827878079cdd906fac167dc40R15-R15) ```diff -genesis-hash = "0c121c75f4ef450f40619e1fca9d1e8e7fbabc42c895bc4790801e85d5a91c34" +genesis-hash = var.genesis_hash ```
    ✨ Improve tool usage guide:
    **Overview:** The `improve` tool scans the PR code changes, and automatically generates suggestions for improving the PR code. The tool can be triggered [automatically](https://pr-agent-docs.codium.ai/usage-guide/automations_and_usage/#github-app-automatic-tools-when-a-new-pr-is-opened) every time a new PR is opened, or can be invoked manually by commenting on a PR. When commenting, to edit [configurations](https://github.com/Codium-ai/pr-agent/blob/main/pr_agent/settings/configuration.toml#L69) related to the improve tool (`pr_code_suggestions` section), use the following template: ``` /improve --pr_code_suggestions.some_config1=... --pr_code_suggestions.some_config2=... ``` With a [configuration file](https://pr-agent-docs.codium.ai/usage-guide/configuration_options/), use the following template: ``` [pr_code_suggestions] some_config1=... some_config2=... ```
    Enabling\disabling automation
    When you first install the app, the [default mode](https://pr-agent-docs.codium.ai/usage-guide/automations_and_usage/#github-app-automatic-tools-when-a-new-pr-is-opened) for the improve tool is: ``` pr_commands = ["/improve --pr_code_suggestions.summarize=true", ...] ``` meaning the `improve` tool will run automatically on every PR, with summarization enabled. Delete this line to disable the tool from running automatically.
    Utilizing extra instructions
    Extra instructions are very important for the `improve` tool, since they enable to guide the model to suggestions that are more relevant to the specific needs of the project. Be specific, clear, and concise in the instructions. With extra instructions, you are the prompter. Specify relevant aspects that you want the model to focus on. Examples for extra instructions: ``` [pr_code_suggestions] # /improve # extra_instructions=""" Emphasize the following aspects: - Does the code logic cover relevant edge cases? - Is the code logic clear and easy to understand? - Is the code logic efficient? ... """ ``` Use triple quotes to write multi-line instructions. Use bullet points to make the instructions more readable.
    A note on code suggestions quality
    - While the current AI for code is getting better and better (GPT-4), it's not flawless. Not all the suggestions will be perfect, and a user should not accept all of them automatically. - Suggestions are not meant to be simplistic. Instead, they aim to give deep feedback and raise questions, ideas and thoughts to the user, who can then use his judgment, experience, and understanding of the code base. - Recommended to use the 'extra_instructions' field to guide the model to suggestions that are more relevant to the specific needs of the project, or use the [custom suggestions :gem:](https://pr-agent-docs.codium.ai/tools/custom_suggestions/) tool - With large PRs, best quality will be obtained by using 'improve --extended' mode.
    More PR-Agent commands
    > To invoke the PR-Agent, add a comment using one of the following commands: > - **/review**: Request a review of your Pull Request. > - **/describe**: Update the PR title and description based on the contents of the PR. > - **/improve [--extended]**: Suggest code improvements. Extended mode provides a higher quality feedback. > - **/ask \**: Ask a question about the PR. > - **/update_changelog**: Update the changelog based on the PR's contents. > - **/add_docs** 💎: Generate docstring for new components introduced in the PR. > - **/generate_labels** 💎: Generate labels for the PR based on the PR's contents. > - **/analyze** 💎: Automatically analyzes the PR, and presents changes walkthrough for each component. >See the [tools guide](https://pr-agent-docs.codium.ai/tools/) for more details. >To list the possible configuration parameters, add a **/config** comment.
    See the [improve usage](https://pr-agent-docs.codium.ai/tools/improve/) page for a more comprehensive guide on using this tool.