search

subspace / space-acres

Space Acres is an opinionated GUI application for farming on Subspace Network
53 stars 18 forks source link

Replace `subspace-runtime` with `subspace-fake-runtime-api` #187

Closed dastansam closed 2 months ago

dastansam commented 2 months ago

companion PR https://github.com/subspace/subspace/pull/2735

Before:

Building [===========>            ] 708/1336:

Now:

 Building [=====================> ] 1257/1268
nazar-pc commented 2 months ago

BTW this PR should proably be updated once upstream PR is merged, so we have commit from main here. I understand why you did it the way you did though.

dastansam commented 2 months ago

Pushed commit that removes genesis config usage, please rebase and squash once upstream PR is updated

thanks, this is a lot better! couldn't think of using () 🤦

BTW this PR should proably be updated once upstream PR is merged, so we have commit from main here. I understand why you did it the way you did though.

yes, I would update the commit hash here once that PR was merged.

nazar-pc commented 2 months ago

thanks, this is a lot better! couldn't think of using () 🤦

That generic is meaningful for legacy API that is soon to be removed from Substrate. When decoding from JSON it is not involved in anything and makes no difference, hence () is fine there and we'll likely remove it in the next Substrate upgrade anyway once it is gone upstream (they promised to remove in March, but it was still in the codebase).