subspace / space-acres

Space Acres is an opinionated GUI application for farming on Subspace Network
53 stars 18 forks source link

Macos dmg support #191

Closed gvzdv closed 1 month ago

gvzdv commented 2 months ago

Created a .dmg file to launch Space Acres on Mac. Created with create-dmg. Tested on Apple Silicon; should also work on Apple Intel. The app is not signed. Info.plist may require adjustments. To create an updated version, run create-dmg '/path_to/space-acres/Space-Acres.app' --overwrite

gvzdv commented 2 months ago

Thank you for reviewing my PR.

I've bitten off more than I could chew with this project. It indeed doesn't work on clean machines and only launched on mine because I already had the necessary libraries installed. I'll see what I can do with it.

Noted regarding binaries and .DS_Store files.

As for the Info.plist file, I will reply to your comments to clarify some details. However, this version of the file is preliminary. When this package is properly compiled and ready for release, we'll need to take a closer look at the Info.plist file to ensure its adherence to the Apple guidelines.

nazar-pc commented 1 month ago

I'll close this for now since we can't merge it as is. Feel free to continue discussion though and we can reopen it (or just create another PR) once more progress is done. Maybe you can also cooperate with @RomanLabGit on this, he indicated working on https://github.com/subspace/space-acres/issues/7 too.