Open rkul opened 3 years ago
Kudos, SonarCloud Quality Gate passed!
0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells
No Coverage information
0.0% Duplication
@rkul can't you just move the file, changing the name? or changing the name when downloading the file?
ex:
sudo mv ~/Downloads/wg0.conf /etc/wireguard/wg_example.conf
@gchamon for sure I can do that, but when I have multiple WG setups for different environments it is a little bit easier to [re]import a config with appropriate name
I understand. Do you think it would be better to customize the connect message using the filename config? Strip the .conf
from the filename var and put it in the message.
Another issue, is that it opens for misconfiguration. Filename must abide to linux naming rules. Do you think we should check that?
@gchamon it would be nice to have customized connect message. As for second point, please check my comment here https://github.com/subspacecommunity/subspace/issues/118#issuecomment-868344105
Actually there is no strict rules, user is able to rename the network device https://systemd.io/PREDICTABLE_INTERFACE_NAMES/ There is always a possibility for misconfiguration, but the default value wg0.conf
should help to avoid most of the issues.
^[a-zA-Z0-9_=+.-]{1,15}$
should be enough to check interface name
I think this feature so useful.
Can't wait to new release!
to: @subspacecommunity/subspace-maintainers resolves: https://github.com/subspacecommunity/subspace/issues/118
Background
There is no way to change config filename, which clients download from UI
Changes
Testing