search

subsquid / squid-sdk

The main repo of the squid SDK
Apache License 2.0
1.23k stars 151 forks source link

Fix ink-v3-schema: dispatchKey is string type #136

Closed HyunggyuJang closed 1 year ago

HyunggyuJang commented 1 year ago

Like cell's key, dispatchKey is always string type.

tmcgroul commented 1 year ago

@HyunggyuJang could you please share details/examples to explain impact of your changes? I took the json schema from some sort of official source - https://github.com/paritytech/ink/blob/master/crates/metadata/ink-v3-schema.json#L220 - is ink's schema invalid?

HyunggyuJang commented 1 year ago

Yes, I think so. https://github.com/AstarNetwork/wasm-showcase-dapps/blob/main/uniswap-v2/contracts/pair/lib.rs is an example at my hand, and indeed all dispatchKey are string as far as know (at least for all contracts in that repo).

HyunggyuJang commented 1 year ago

Thanks for guiding me to parity’s repo, @tmcgroul. Think I should make an issue or PR in that repo also.

HyunggyuJang commented 1 year ago

Just note that, with the up-to-date schema file, the one from your template is also invalid.