Click on active subject reference bracket leaves you in a active state again, 3rd click does what the second click should do - Githubissues

substance / archivist-composer

A composer for interviews, used by the archivist project

MIT License

2 stars 0 forks source link

Click on active subject reference bracket leaves you in a active state again, 3rd click does what the second click should do #20

Closed michael closed 9 years ago

michael commented 9 years ago

Following situation:

select some text inside of a paragraph (PropertySelection)
click subject reference bracket to highlight that subject reference
now click again on reference bracket

Expected: should be disabled now Actual: it stays open

What happened?

selection change event gets fired right before second toggle (core extension switches state to default state)
toggle reference code than does the check if contextId = editSubjectReference and finds it's not so it activates it again.

Possible problem:

property selection somehow does not get cleared after first click
second toggle click leads to a blur finally and triggers the unwanted state change..

not sure how we should deal with that kind of problems... Oliver?

michael commented 9 years ago

Fixed.