search

substance / lens

Lens - open science content creation and display
http://substance.io/lens
MIT License
124 stars 20 forks source link

Don't rely on globals #35

Closed jure closed 8 years ago

jure commented 8 years ago

Please don't rely on global variables, i.e. i18n in https://github.com/substance/lens-writer/blob/master/src/components/content_toolbar.js#L32 or React in https://github.com/substance/lens-writer/blob/master/src/components/content_toolbar.js#L12

This makes development difficult for people who are integrating lens-writer into different contexts.

michael commented 8 years ago

No globals anymore.

jure commented 8 years ago

:+1: awesome!