search

substance / notes

Real-time collaborative notes editing.
Other
21 stars 5 forks source link

move api.js to Substance CollabHub implementation #26

Closed michael closed 8 years ago

michael commented 8 years ago

This should sit inside addRoutes method of CollabHub (work in a branch on substance repo, base it on improved-collabsession branch.

Implementation of upload figure including dependencies (multer etc.) should go into hub/ChangesStore.js

Remember that in Substance land we just want interfaces we can call without implementation dependencies (no sql, no multer etc. stuff).

We may rename store to backend at some point.

Work on the session user store first, and grab this if you run out of work.

Integral commented 8 years ago

Hmm, not sure that it is a good idea - store routes inside CollabHub. The problem here is that while we are going to do everything with express library, I'm not sure that anybody wants it. So we should also be abstract here. I will check whatever it's possible to use the same notation with koa.

On Sat, Feb 20, 2016, 16:39 Michael Aufreiter notifications@github.com wrote:

Assigned #26 https://github.com/substance/notepad/issues/26 to @Integral https://github.com/Integral.

— Reply to this email directly or view it on GitHub https://github.com/substance/notepad/issues/26#event-557526512.

michael commented 8 years ago

Express is the quasi-standard. 99% of node apps use express. It's fine if we bind to that for now. I'm open for suggestions to do it better.

What I want to acchieve is having the functionality within CollabHub, so it comes as one package. And i also just want one line to activate it in server.js.

Integral commented 8 years ago

Yes, I understand...

On Sat, Feb 20, 2016, 19:28 Michael Aufreiter notifications@github.com wrote:

Express is the quasi-standard. 99% of node apps use express. It's fine if we bind to that for now. I'm open for suggestions to do it better.

What I want to acchieve is having the functionality within CollabHub, so it comes as one package. And i also just want one line to activate it in server.js.

— Reply to this email directly or view it on GitHub https://github.com/substance/notepad/issues/26#issuecomment-186625547.

Integral commented 8 years ago

closing, take a look at #32